threads / patch / 19861

patchfix stg mail %(shortlog)s order

Subject: [StGit PATCH] fix stg mail %(shortlog)s order

## tl;dr

One message between Jun 19, 2009 and Jun 19, 2009. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Alex Chiang· Jun 19, 2009, 05:30 UTC · lore

When using the %(shortlog)s variable, the patches are listed in the cover letter in the reverse order of the actual patch series.

We should list them in the actual order of the patch series instead.
Signed-off-by: Alex Chiang <achiang@hp.com>
---
Show changes to stgit/commands/mail.py +1 −1
diff --git a/stgit/commands/mail.py b/stgit/commands/mail.py
index 69b19fa..abd42e4 100644
--- a/stgit/commands/mail.py
+++ b/stgit/commands/mail.py
@@ -399,7 +399,7 @@ def __build_cover(tmpl, patches, msg_id, options):
                  'totalnr':      total_nr_str,
                  'number':       number_str,
                  'shortlog':     stack.shortlog(crt_series.get_patch(p)
-                                                for p in patches),
+                                                for p in reversed(patches)),
                  'diffstat':     gitlib.diffstat(git.diff(
                      rev1 = git_id(crt_series, '%s^' % patches[0]),
                      rev2 = git_id(crt_series, '%s' % patches[-1]),

← back to recent threads