# [StGit PATCH] fix stg mail %(shortlog)s order

1 messages from 2009-06-19 to 2009-06-19. Participants: Alex Chiang.
Thread: https://gitlist.dev/t/19861

## Alex Chiang, 2009-06-19 05:30

Subject: [StGit PATCH] fix stg mail %(shortlog)s order
Message-ID: <20090619053040.GE21764@ldl.fc.hp.com>
URL: https://gitlist.dev/e/20090619053040.GE21764%40ldl.fc.hp.com

```
When using the %(shortlog)s variable, the patches are listed in
the cover letter in the reverse order of the actual patch series.

We should list them in the actual order of the patch series instead.

Signed-off-by: Alex Chiang <achiang@hp.com>
---
diff --git a/stgit/commands/mail.py b/stgit/commands/mail.py
index 69b19fa..abd42e4 100644
--- a/stgit/commands/mail.py
+++ b/stgit/commands/mail.py
@@ -399,7 +399,7 @@ def __build_cover(tmpl, patches, msg_id, options):
                  'totalnr':      total_nr_str,
                  'number':       number_str,
                  'shortlog':     stack.shortlog(crt_series.get_patch(p)
-                                                for p in patches),
+                                                for p in reversed(patches)),
                  'diffstat':     gitlib.diffstat(git.diff(
                      rev1 = git_id(crt_series, '%s^' % patches[0]),
                      rev2 = git_id(crt_series, '%s' % patches[-1]),

```