git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[StGit PATCH] fix stg mail %(shortlog)s order

From
ACAlex Chiang <achiang@hp.com>
Date
Jun 19, 2009, 05:30 UTC
Message-ID
<20090619053040.GE21764@ldl.fc.hp.com>

When using the %(shortlog)s variable, the patches are listed in the cover letter in the reverse order of the actual patch series.

We should list them in the actual order of the patch series instead.
Signed-off-by: Alex Chiang <achiang@hp.com>
---
diff --git a/stgit/commands/mail.py b/stgit/commands/mail.py
index 69b19fa..abd42e4 100644
--- a/stgit/commands/mail.py
+++ b/stgit/commands/mail.py
@@ -399,7 +399,7 @@ def __build_cover(tmpl, patches, msg_id, options):
                  'totalnr':      total_nr_str,
                  'number':       number_str,
                  'shortlog':     stack.shortlog(crt_series.get_patch(p)
-                                                for p in patches),
+                                                for p in reversed(patches)),
                  'diffstat':     gitlib.diffstat(git.diff(
                      rev1 = git_id(crt_series, '%s^' % patches[0]),
                      rev2 = git_id(crt_series, '%s' % patches[-1]),
Message 1 of 1 in “fix stg mail %(shortlog)s order”
  1. fix stg mail %(shortlog)s orderAlex Chiang, Jun 19, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.