threads / patch / 19689

patch, 23 partstransport.c::get_refs_via_curl(): do not leak refs_url

Subject: [PATCH 12/23] transport.c::get_refs_via_curl(): do not leak refs_url

## tl;dr

3 messages between Jun 5, 2009 and Jun 6, 2009. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Tay Ray Chuan· Jun 5, 2009, 16:04 UTC · lore

From:	Mike Hommey <mh@glandium.org>
Subject: [WIP Patch 02/12] Some cleanup in get_refs_via_curl()
Date:	Sun, 18 Jan 2009 09:04:27 +0100

Signed-off-by: Mike Hommey <mh@glandium.org>
Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
---
 transport.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Show changes to transport.c +1 −1

diff --git a/transport.c b/transport.c
index efecb65..9edd5aa 100644
--- a/transport.c
+++ b/transport.c
@@ -519,6 +519,7 @@ static struct ref *get_refs_via_curl(struct transport *transport, int for_push)
 		free(ref);
 	}

+	free(refs_url);
 	return refs;
 }

--
1.6.3.1

Jakub Narebski· Jun 5, 2009, 20:46 UTC · re: Tay Ray Chuan · lore

Re: [PATCH 12/23] transport.c::get_refs_via_curl(): do not leak refs_url

Tay Ray Chuan <rctay89@gmail.com> writes:

> From:	Mike Hommey <mh@glandium.org>
> Subject: [WIP Patch 02/12] Some cleanup in get_refs_via_curl()

So what is the title of this patch? "transport.c::get_refs_via_curl(): do not leak refs_url" or "Some cleanup in get_refs_via_curl()"?

Perhaps it should be "transport.c: Do not leak refs_url in get_refs_via_curl()"...?

Show 23 quoted lines

> Date:	Sun, 18 Jan 2009 09:04:27 +0100
> 
> Signed-off-by: Mike Hommey <mh@glandium.org>
> Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
> ---
>  transport.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/transport.c b/transport.c
> index efecb65..9edd5aa 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -519,6 +519,7 @@ static struct ref *get_refs_via_curl(struct transport *transport, int for_push)
>  		free(ref);
>  	}
> 
> +	free(refs_url);
>  	return refs;
>  }
> 
> --
> 1.6.3.1
>

-- 
Jakub Narebski
Poland
ShadeHawk on #git

Tay Ray Chuan· Jun 6, 2009, 01:04 UTC · re: Jakub Narebski · lore

Re: [PATCH 12/23] transport.c::get_refs_via_curl(): do not leak refs_url

Hi,

On Sat, Jun 6, 2009 at 4:46 AM, Jakub Narebski<jnareb@gmail.com> wrote:

Show 5 quoted lines

>> From: Mike Hommey <mh@glandium.org>
>> Subject: [WIP Patch 02/12] Some cleanup in get_refs_via_curl()
>
> So what is the title of this patch? "transport.c::get_refs_via_curl():
> do not leak refs_url" or "Some cleanup in get_refs_via_curl()"?

See my reply to patch #19.

> Perhaps it should be "transport.c: Do not leak refs_url in
> get_refs_via_curl()"...?

I think it's a matter of preference. I'll put them side-by-side to demonstrate this better:

transport.c: Do not leak refs_url in get_refs_via_curl() transport.c::get_refs_via_curl(): do not leak refs_url

There isn't any important difference between the two other than form.

-- 
Cheers,
Ray Chuan