Re: [PATCH 12/23] transport.c::get_refs_via_curl(): do not leak refs_url

From: Jakub Narebski <jnareb@gmail.com>
Date: Jun 5, 2009, 20:46 UTC
Message-ID: <m3my8m5ryh.fsf@localhost.localdomain>
In-Reply-To: <20090606000451.262b7711.rctay89@gmail.com>

Tay Ray Chuan <rctay89@gmail.com> writes:

> From:	Mike Hommey <mh@glandium.org>
> Subject: [WIP Patch 02/12] Some cleanup in get_refs_via_curl()

So what is the title of this patch? "transport.c::get_refs_via_curl(): do not leak refs_url" or "Some cleanup in get_refs_via_curl()"?

Perhaps it should be "transport.c: Do not leak refs_url in get_refs_via_curl()"...?

Show 23 quoted lines

> Date:	Sun, 18 Jan 2009 09:04:27 +0100
> 
> Signed-off-by: Mike Hommey <mh@glandium.org>
> Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
> ---
>  transport.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/transport.c b/transport.c
> index efecb65..9edd5aa 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -519,6 +519,7 @@ static struct ref *get_refs_via_curl(struct transport *transport, int for_push)
>  		free(ref);
>  	}
> 
> +	free(refs_url);
>  	return refs;
>  }
> 
> --
> 1.6.3.1
>

-- 
Jakub Narebski
Poland
ShadeHawk on #git