{"thread":{"id":"19689","subject":"[PATCH 12/23] transport.c::get_refs_via_curl(): do not leak refs_url","startedAt":"2009-06-05T16:04:51Z","lastAt":"2009-06-06T01:04:35Z","messageCount":3,"participants":["Tay Ray Chuan","Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":23},"messages":[{"id":"115525","messageId":"20090606000451.262b7711.rctay89@gmail.com","threadId":"19689","inReplyTo":null,"subject":"[PATCH 12/23] transport.c::get_refs_via_curl(): do not leak refs_url","fromName":"Tay Ray Chuan","fromEmail":"rctay89@gmail.com","sentAt":"2009-06-05T16:04:51Z","receivedAt":"2009-06-05T16:04:51Z","isPatch":true,"sender":{"key":"rctay89@gmail.com","avatar":"https://avatars.githubusercontent.com/u/61553?v=4"},"body":"From:\tMike Hommey <mh@glandium.org>\nSubject: [WIP Patch 02/12] Some cleanup in get_refs_via_curl()\nDate:\tSun, 18 Jan 2009 09:04:27 +0100\n\nSigned-off-by: Mike Hommey <mh@glandium.org>\nSigned-off-by: Tay Ray Chuan <rctay89@gmail.com>\n---\n transport.c |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/transport.c b/transport.c\nindex efecb65..9edd5aa 100644\n--- a/transport.c\n+++ b/transport.c\n@@ -519,6 +519,7 @@ static struct ref *get_refs_via_curl(struct transport *transport, int for_push)\n \t\tfree(ref);\n \t}\n\n+\tfree(refs_url);\n \treturn refs;\n }\n\n--\n1.6.3.1\n"},{"id":"115564","messageId":"m3my8m5ryh.fsf@localhost.localdomain","threadId":"19689","inReplyTo":"20090606000451.262b7711.rctay89@gmail.com","subject":"Re: [PATCH 12/23] transport.c::get_refs_via_curl(): do not leak refs_url","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2009-06-05T20:46:48Z","receivedAt":"2009-06-05T20:46:48Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Tay Ray Chuan <rctay89@gmail.com> writes:\n\n> From:\tMike Hommey <mh@glandium.org>\n> Subject: [WIP Patch 02/12] Some cleanup in get_refs_via_curl()\n\nSo what is the title of this patch? \"transport.c::get_refs_via_curl():\ndo not leak refs_url\" or \"Some cleanup in get_refs_via_curl()\"?\n\nPerhaps it should be \"transport.c: Do not leak refs_url in\nget_refs_via_curl()\"...?\n\n> Date:\tSun, 18 Jan 2009 09:04:27 +0100\n> \n> Signed-off-by: Mike Hommey <mh@glandium.org>\n> Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>\n> ---\n>  transport.c |    1 +\n>  1 files changed, 1 insertions(+), 0 deletions(-)\n> \n> diff --git a/transport.c b/transport.c\n> index efecb65..9edd5aa 100644\n> --- a/transport.c\n> +++ b/transport.c\n> @@ -519,6 +519,7 @@ static struct ref *get_refs_via_curl(struct transport *transport, int for_push)\n>  \t\tfree(ref);\n>  \t}\n> \n> +\tfree(refs_url);\n>  \treturn refs;\n>  }\n> \n> --\n> 1.6.3.1\n> \n\n-- \nJakub Narebski\nPoland\nShadeHawk on #git\n"},{"id":"115587","messageId":"be6fef0d0906051804k4d574d39v37dedf46896cb570@mail.gmail.com","threadId":"19689","inReplyTo":"m3my8m5ryh.fsf@localhost.localdomain","subject":"Re: [PATCH 12/23] transport.c::get_refs_via_curl(): do not leak refs_url","fromName":"Tay Ray Chuan","fromEmail":"rctay89@gmail.com","sentAt":"2009-06-06T01:04:35Z","receivedAt":"2009-06-06T01:04:35Z","isPatch":true,"sender":{"key":"rctay89@gmail.com","avatar":"https://avatars.githubusercontent.com/u/61553?v=4"},"body":"Hi,\n\nOn Sat, Jun 6, 2009 at 4:46 AM, Jakub Narebski<jnareb@gmail.com> wrote:\n>> From: Mike Hommey <mh@glandium.org>\n>> Subject: [WIP Patch 02/12] Some cleanup in get_refs_via_curl()\n>\n> So what is the title of this patch? \"transport.c::get_refs_via_curl():\n> do not leak refs_url\" or \"Some cleanup in get_refs_via_curl()\"?\n\nSee my reply to patch #19.\n\n> Perhaps it should be \"transport.c: Do not leak refs_url in\n> get_refs_via_curl()\"...?\n\nI think it's a matter of preference. I'll put them side-by-side to\ndemonstrate this better:\n\ntransport.c: Do not leak refs_url in get_refs_via_curl()\ntransport.c::get_refs_via_curl(): do not leak refs_url\n\nThere isn't any important difference between the two other than form.\n\n-- \nCheers,\nRay Chuan\n"}]}