[PATCH 07/18] Some cleanup in get_refs_via_curl()

Tay Ray Chuan· May 24, 2009, 14:19 UTC · lore

Signed-off-by: Mike Hommey <mh@glandium.org>
Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
---
 transport.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Show changes to transport.c +1 −1

diff --git a/transport.c b/transport.c
index 89d846e..b7c1c39 100644
--- a/transport.c
+++ b/transport.c
@@ -519,6 +519,7 @@ static struct ref *get_refs_via_curl(struct transport *transport, int for_push)
 		free(ref);
 	}

+	free(refs_url);
 	return refs;
 }

--
1.6.3.1

Junio C Hamano· May 24, 2009, 20:43 UTC · re: Tay Ray Chuan · lore

Re: [PATCH 07/18] Some cleanup in get_refs_via_curl()

Tay Ray Chuan <rctay89@gmail.com> writes:

> Signed-off-by: Mike Hommey <mh@glandium.org>
> Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>

The same comment as 06/18 on attribution apllies.

Be specific when you can without going to too verbose. In this case, instead of wasting two meaningless words "Some cleanup", you can say:

	Subject: transport.c::get_refs_via_curl(): do not leak refs_url

Show 17 quoted lines

>  transport.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/transport.c b/transport.c
> index 89d846e..b7c1c39 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -519,6 +519,7 @@ static struct ref *get_refs_via_curl(struct transport *transport, int for_push)
>  		free(ref);
>  	}
>
> +	free(refs_url);
>  	return refs;
>  }
>
> --
> 1.6.3.1

patch, 18 partsSome cleanup in get_refs_via_curl()