# [PATCH 07/18] Some cleanup in get_refs_via_curl() 2 messages from 2009-05-24 to 2009-05-24. Participants: Tay Ray Chuan, Junio C Hamano. Thread: https://gitlist.dev/t/19477 ## Tay Ray Chuan, 2009-05-24 14:19 Subject: [PATCH 07/18] Some cleanup in get_refs_via_curl() Message-ID: <20090524221949.4e61f987.rctay89@gmail.com> URL: https://gitlist.dev/e/20090524221949.4e61f987.rctay89%40gmail.com ``` Signed-off-by: Mike Hommey Signed-off-by: Tay Ray Chuan --- transport.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/transport.c b/transport.c index 89d846e..b7c1c39 100644 --- a/transport.c +++ b/transport.c @@ -519,6 +519,7 @@ static struct ref *get_refs_via_curl(struct transport *transport, int for_push) free(ref); } + free(refs_url); return refs; } -- 1.6.3.1 ``` ## Junio C Hamano, 2009-05-24 20:43 Subject: Re: [PATCH 07/18] Some cleanup in get_refs_via_curl() Message-ID: <7vskiuteo1.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vskiuteo1.fsf%40alter.siamese.dyndns.org In-Reply-To: <20090524221949.4e61f987.rctay89@gmail.com> ``` Tay Ray Chuan writes: > Signed-off-by: Mike Hommey > Signed-off-by: Tay Ray Chuan The same comment as 06/18 on attribution apllies. Be specific when you can without going to too verbose. In this case, instead of wasting two meaningless words "Some cleanup", you can say: Subject: transport.c::get_refs_via_curl(): do not leak refs_url > transport.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/transport.c b/transport.c > index 89d846e..b7c1c39 100644 > --- a/transport.c > +++ b/transport.c > @@ -519,6 +519,7 @@ static struct ref *get_refs_via_curl(struct transport *transport, int for_push) > free(ref); > } > > + free(refs_url); > return refs; > } > > -- > 1.6.3.1 ```