{"thread":{"id":"19477","subject":"[PATCH 07/18] Some cleanup in get_refs_via_curl()","startedAt":"2009-05-24T14:19:49Z","lastAt":"2009-05-24T20:43:42Z","messageCount":2,"participants":["Tay Ray Chuan","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":18},"messages":[{"id":"114568","messageId":"20090524221949.4e61f987.rctay89@gmail.com","threadId":"19477","inReplyTo":null,"subject":"[PATCH 07/18] Some cleanup in get_refs_via_curl()","fromName":"Tay Ray Chuan","fromEmail":"rctay89@gmail.com","sentAt":"2009-05-24T14:19:49Z","receivedAt":"2009-05-24T14:19:49Z","isPatch":true,"sender":{"key":"rctay89@gmail.com","avatar":"https://avatars.githubusercontent.com/u/61553?v=4"},"body":"Signed-off-by: Mike Hommey <mh@glandium.org>\nSigned-off-by: Tay Ray Chuan <rctay89@gmail.com>\n---\n transport.c |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/transport.c b/transport.c\nindex 89d846e..b7c1c39 100644\n--- a/transport.c\n+++ b/transport.c\n@@ -519,6 +519,7 @@ static struct ref *get_refs_via_curl(struct transport *transport, int for_push)\n \t\tfree(ref);\n \t}\n\n+\tfree(refs_url);\n \treturn refs;\n }\n\n--\n1.6.3.1\n"},{"id":"114597","messageId":"7vskiuteo1.fsf@alter.siamese.dyndns.org","threadId":"19477","inReplyTo":"20090524221949.4e61f987.rctay89@gmail.com","subject":"Re: [PATCH 07/18] Some cleanup in get_refs_via_curl()","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-05-24T20:43:42Z","receivedAt":"2009-05-24T20:43:42Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Tay Ray Chuan <rctay89@gmail.com> writes:\n\n> Signed-off-by: Mike Hommey <mh@glandium.org>\n> Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>\n\nThe same comment as 06/18 on attribution apllies.\n\nBe specific when you can without going to too verbose.  In this case,\ninstead of wasting two meaningless words \"Some cleanup\", you can say:\n\n\tSubject: transport.c::get_refs_via_curl(): do not leak refs_url\n\n>  transport.c |    1 +\n>  1 files changed, 1 insertions(+), 0 deletions(-)\n>\n> diff --git a/transport.c b/transport.c\n> index 89d846e..b7c1c39 100644\n> --- a/transport.c\n> +++ b/transport.c\n> @@ -519,6 +519,7 @@ static struct ref *get_refs_via_curl(struct transport *transport, int for_push)\n>  \t\tfree(ref);\n>  \t}\n>\n> +\tfree(refs_url);\n>  \treturn refs;\n>  }\n>\n> --\n> 1.6.3.1\n"}]}