[PATCH] Makefile: ignore perl/ subdirectory under NO_PERL

Junio C Hamano· Apr 23, 2009, 05:42 UTC · lore

The install target still descends into perl subdirectory when NO_PERL is requested. Fix this.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

 * I think the very original from Robin had this exclusion, but somehow it
   seems to have got lost.  Right now, perl/Makefile does not do anything
   that depends on having perl, but I think we do not have/need to rely on
   that.

 Makefile |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Show changes to Makefile +2 −0

diff --git a/Makefile b/Makefile
index 49f36f5..6f602c7 100644
--- a/Makefile
+++ b/Makefile
@@ -1529,7 +1529,9 @@ install: all
 	$(INSTALL) $(ALL_PROGRAMS) '$(DESTDIR_SQ)$(gitexec_instdir_SQ)'
 	$(INSTALL) git$X git-upload-pack$X git-receive-pack$X git-upload-archive$X git-shell$X git-cvsserver '$(DESTDIR_SQ)$(bindir_SQ)'
 	$(MAKE) -C templates DESTDIR='$(DESTDIR_SQ)' install
+ifndef NO_PERL
 	$(MAKE) -C perl prefix='$(prefix_SQ)' DESTDIR='$(DESTDIR_SQ)' install
+endif
 ifndef NO_TCLTK
 	$(MAKE) -C gitk-git install
 	$(MAKE) -C git-gui gitexecdir='$(gitexec_instdir_SQ)' install

Jeff King· Apr 23, 2009, 11:17 UTC · re: Junio C Hamano · lore

Re: [PATCH] Makefile: ignore perl/ subdirectory under NO_PERL

On Wed, Apr 22, 2009 at 10:42:28PM -0700, Junio C Hamano wrote:

> The install target still descends into perl subdirectory when NO_PERL is
> requested.  Fix this.

Oops, good catch.

Acked-by: Jeff King <peff@peff.net>

-Peff

patchMakefile: ignore perl/ subdirectory under NO_PERL