# [PATCH] Makefile: ignore perl/ subdirectory under NO_PERL 2 messages from 2009-04-23 to 2009-04-23. Participants: Junio C Hamano, Jeff King. Thread: https://gitlist.dev/t/19015 ## Junio C Hamano, 2009-04-23 05:42 Subject: [PATCH] Makefile: ignore perl/ subdirectory under NO_PERL Message-ID: <7v3ac0x6wr.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7v3ac0x6wr.fsf%40gitster.siamese.dyndns.org ``` The install target still descends into perl subdirectory when NO_PERL is requested. Fix this. Signed-off-by: Junio C Hamano --- * I think the very original from Robin had this exclusion, but somehow it seems to have got lost. Right now, perl/Makefile does not do anything that depends on having perl, but I think we do not have/need to rely on that. Makefile | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index 49f36f5..6f602c7 100644 --- a/Makefile +++ b/Makefile @@ -1529,7 +1529,9 @@ install: all $(INSTALL) $(ALL_PROGRAMS) '$(DESTDIR_SQ)$(gitexec_instdir_SQ)' $(INSTALL) git$X git-upload-pack$X git-receive-pack$X git-upload-archive$X git-shell$X git-cvsserver '$(DESTDIR_SQ)$(bindir_SQ)' $(MAKE) -C templates DESTDIR='$(DESTDIR_SQ)' install +ifndef NO_PERL $(MAKE) -C perl prefix='$(prefix_SQ)' DESTDIR='$(DESTDIR_SQ)' install +endif ifndef NO_TCLTK $(MAKE) -C gitk-git install $(MAKE) -C git-gui gitexecdir='$(gitexec_instdir_SQ)' install ``` ## Jeff King, 2009-04-23 11:17 Subject: Re: [PATCH] Makefile: ignore perl/ subdirectory under NO_PERL Message-ID: <20090423111738.GA3670@sigill.intra.peff.net> URL: https://gitlist.dev/e/20090423111738.GA3670%40sigill.intra.peff.net In-Reply-To: <7v3ac0x6wr.fsf@gitster.siamese.dyndns.org> ``` On Wed, Apr 22, 2009 at 10:42:28PM -0700, Junio C Hamano wrote: > The install target still descends into perl subdirectory when NO_PERL is > requested. Fix this. Oops, good catch. Acked-by: Jeff King -Peff ```