{"thread":{"id":"19015","subject":"[PATCH] Makefile: ignore perl/ subdirectory under NO_PERL","startedAt":"2009-04-23T05:42:28Z","lastAt":"2009-04-23T11:17:42Z","messageCount":2,"participants":["Junio C Hamano","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"112046","messageId":"7v3ac0x6wr.fsf@gitster.siamese.dyndns.org","threadId":"19015","inReplyTo":null,"subject":"[PATCH] Makefile: ignore perl/ subdirectory under NO_PERL","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-04-23T05:42:28Z","receivedAt":"2009-04-23T05:42:28Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"The install target still descends into perl subdirectory when NO_PERL is\nrequested.  Fix this.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n\n * I think the very original from Robin had this exclusion, but somehow it\n   seems to have got lost.  Right now, perl/Makefile does not do anything\n   that depends on having perl, but I think we do not have/need to rely on\n   that.\n\n Makefile |    2 ++\n 1 files changed, 2 insertions(+), 0 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 49f36f5..6f602c7 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1529,7 +1529,9 @@ install: all\n \t$(INSTALL) $(ALL_PROGRAMS) '$(DESTDIR_SQ)$(gitexec_instdir_SQ)'\n \t$(INSTALL) git$X git-upload-pack$X git-receive-pack$X git-upload-archive$X git-shell$X git-cvsserver '$(DESTDIR_SQ)$(bindir_SQ)'\n \t$(MAKE) -C templates DESTDIR='$(DESTDIR_SQ)' install\n+ifndef NO_PERL\n \t$(MAKE) -C perl prefix='$(prefix_SQ)' DESTDIR='$(DESTDIR_SQ)' install\n+endif\n ifndef NO_TCLTK\n \t$(MAKE) -C gitk-git install\n \t$(MAKE) -C git-gui gitexecdir='$(gitexec_instdir_SQ)' install\n"},{"id":"112078","messageId":"20090423111738.GA3670@sigill.intra.peff.net","threadId":"19015","inReplyTo":"7v3ac0x6wr.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] Makefile: ignore perl/ subdirectory under NO_PERL","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2009-04-23T11:17:42Z","receivedAt":"2009-04-23T11:17:42Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Apr 22, 2009 at 10:42:28PM -0700, Junio C Hamano wrote:\n\n> The install target still descends into perl subdirectory when NO_PERL is\n> requested.  Fix this.\n\nOops, good catch.\n\nAcked-by: Jeff King <peff@peff.net>\n\n-Peff\n"}]}