threads / discuss / 1900

git/Documentation/Makefile - "install" doesn't depend on "all"

Subject: git/Documentation/Makefile - "install" doesn't depend on "all"

## tl;dr

2 messages between Sep 21, 2005 and Sep 21, 2005.

replies: 1people: 2as markdown or json

Randal L. Schwartz· Sep 21, 2005, 17:12 UTC · lore

I traditionally simply say "make install" to a Makefile, which should always have the installed components depend on their sources.

For the past few days, apparently I've been doing nothing but the final "install" command, even though the sources have been changed.

On a whim, I typed "make all install", and there ya go, everything got made.

So, apparently, the manpages don't properly depend on the sources, or "install" doesn't properly depend on "all", or both.

Therefore, broken.

-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!

Junio C Hamano· Sep 21, 2005, 18:36 UTC · re: Randal L. Schwartz · lore

Re: git/Documentation/Makefile - "install" doesn't depend on "all"

merlyn@stonehenge.com (Randal L. Schwartz) writes:

> So, apparently, the manpages don't properly depend on the sources,
> or "install" doesn't properly depend on "all", or both.
>
> Therefore, broken.

Thanks for the patch.

------------ git diff

diff --git a/Documentation/Makefile b/Documentation/Makefile
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -44,7 +44,7 @@ man: man1 man7
 man1: $(DOC_MAN1)
 man7: $(DOC_MAN7)
 
-install:
+install: all
 	$(INSTALL) -d -m755 $(DESTDIR)/$(man1) $(DESTDIR)/$(man7)
 	$(INSTALL) $(DOC_MAN1) $(DESTDIR)/$(man1)
 	$(INSTALL) $(DOC_MAN7) $(DESTDIR)/$(man7)