# git/Documentation/Makefile - "install" doesn't depend on "all" 2 messages from 2005-09-21 to 2005-09-21. Participants: Randal L. Schwartz, Junio C Hamano. Thread: https://gitlist.dev/t/1900 ## Randal L. Schwartz, 2005-09-21 17:12 Subject: git/Documentation/Makefile - "install" doesn't depend on "all" Message-ID: <868xxq73az.fsf@blue.stonehenge.com> URL: https://gitlist.dev/e/868xxq73az.fsf%40blue.stonehenge.com ``` I traditionally simply say "make install" to a Makefile, which should always have the installed components depend on their sources. For the past few days, apparently I've been doing nothing but the final "install" command, even though the sources have been changed. On a whim, I typed "make all install", and there ya go, everything got made. So, apparently, the manpages don't properly depend on the sources, or "install" doesn't properly depend on "all", or both. Therefore, broken. -- Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095 Perl/Unix/security consulting, Technical writing, Comedy, etc. etc. See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training! ``` ## Junio C Hamano, 2005-09-21 18:36 Subject: Re: git/Documentation/Makefile - "install" doesn't depend on "all" Message-ID: <7vbr2mw9na.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vbr2mw9na.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <868xxq73az.fsf@blue.stonehenge.com> ``` merlyn@stonehenge.com (Randal L. Schwartz) writes: > So, apparently, the manpages don't properly depend on the sources, > or "install" doesn't properly depend on "all", or both. > > Therefore, broken. Thanks for the patch. ------------ git diff diff --git a/Documentation/Makefile b/Documentation/Makefile --- a/Documentation/Makefile +++ b/Documentation/Makefile @@ -44,7 +44,7 @@ man: man1 man7 man1: $(DOC_MAN1) man7: $(DOC_MAN7) -install: +install: all $(INSTALL) -d -m755 $(DESTDIR)/$(man1) $(DESTDIR)/$(man7) $(INSTALL) $(DOC_MAN1) $(DESTDIR)/$(man1) $(INSTALL) $(DOC_MAN7) $(DESTDIR)/$(man7) ```