{"thread":{"id":"1900","subject":"git/Documentation/Makefile - \"install\" doesn't depend on \"all\"","startedAt":"2005-09-21T17:12:36Z","lastAt":"2005-09-21T18:36:25Z","messageCount":2,"participants":["Randal L. Schwartz","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"9058","messageId":"868xxq73az.fsf@blue.stonehenge.com","threadId":"1900","inReplyTo":null,"subject":"git/Documentation/Makefile - \"install\" doesn't depend on \"all\"","fromName":"Randal L. Schwartz","fromEmail":"merlyn@stonehenge.com","sentAt":"2005-09-21T17:12:36Z","receivedAt":"2005-09-21T17:12:36Z","isPatch":false,"sender":{"key":"merlyn@stonehenge.com","avatar":"https://gravatar.com/avatar/dc528d210743ff0333e6213f9ee7b33b23f1b7bc1f3c5a8c2d819074ecd7ab19?d=mp&s=160"},"body":"\nI traditionally simply say \"make install\" to a Makefile, which should\nalways have the installed components depend on their sources.\n\nFor the past few days, apparently I've been doing nothing but the final\n\"install\" command, even though the sources have been changed.\n\nOn a whim, I typed \"make all install\", and there ya go, everything got\nmade.\n\nSo, apparently, the manpages don't properly depend on the sources,\nor \"install\" doesn't properly depend on \"all\", or both.\n\nTherefore, broken.\n\n-- \nRandal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095\n<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>\nPerl/Unix/security consulting, Technical writing, Comedy, etc. etc.\nSee PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!\n"},{"id":"9061","messageId":"7vbr2mw9na.fsf@assigned-by-dhcp.cox.net","threadId":"1900","inReplyTo":"868xxq73az.fsf@blue.stonehenge.com","subject":"Re: git/Documentation/Makefile - \"install\" doesn't depend on \"all\"","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-09-21T18:36:25Z","receivedAt":"2005-09-21T18:36:25Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"merlyn@stonehenge.com (Randal L. Schwartz) writes:\n\n> So, apparently, the manpages don't properly depend on the sources,\n> or \"install\" doesn't properly depend on \"all\", or both.\n>\n> Therefore, broken.\n\nThanks for the patch.\n\n------------\ngit diff\ndiff --git a/Documentation/Makefile b/Documentation/Makefile\n--- a/Documentation/Makefile\n+++ b/Documentation/Makefile\n@@ -44,7 +44,7 @@ man: man1 man7\n man1: $(DOC_MAN1)\n man7: $(DOC_MAN7)\n \n-install:\n+install: all\n \t$(INSTALL) -d -m755 $(DESTDIR)/$(man1) $(DESTDIR)/$(man7)\n \t$(INSTALL) $(DOC_MAN1) $(DESTDIR)/$(man1)\n \t$(INSTALL) $(DOC_MAN7) $(DESTDIR)/$(man7)\n"}]}