threads / patch / 18884

patchgitk: avoid crash if closed while reading references

Subject: [PATCH] gitk: avoid crash if closed while reading references

## tl;dr

2 messages between Apr 15, 2009 and Apr 15, 2009. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Pat Thoyts· Apr 15, 2009, 16:14 UTC · lore

  As recorded in msysGit issue 125 if the user closes gitk while it
  reports itself as still reading references then Tk will crash in the
  geometry management code. This has been fixed for Tk 8.5.7 and above.
  This patch avoids the problem by flushing outstanding geometry events
  before calling the readrefs procedure.

  See also http://code.google.com/p/msysgit/issues/detail?id=125

Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
---
 gitk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Show changes to gitk +1 −0

diff --git a/gitk b/gitk
index 656c2c1..a346bd5 100755
--- a/gitk
+++ b/gitk
@@ -10952,6 +10952,7 @@ catch {
 # wait for the window to become visible
 tkwait visibility .
 wm title . "[file tail $argv0]: [file tail [pwd]]"
+update
 readrefs
 
 if {$cmdline_files ne {} || $revtreeargs ne {} || $revtreeargscmd ne {}} {

-- 
1.6.2.2.1669.g7eaf8

Johannes Schindelin· Apr 15, 2009, 16:46 UTC · re: Pat Thoyts · lore

Re: [PATCH] gitk: avoid crash if closed while reading references

Hi,

On Wed, 15 Apr 2009, Pat Thoyts wrote:

Show 10 quoted lines

> 
>   As recorded in msysGit issue 125 if the user closes gitk while it
>   reports itself as still reading references then Tk will crash in the
>   geometry management code. This has been fixed for Tk 8.5.7 and above.
>   This patch avoids the problem by flushing outstanding geometry events
>   before calling the readrefs procedure.
> 
>   See also http://code.google.com/p/msysgit/issues/detail?id=125
> 
> Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>

This is commit 3d3ecb65e34a62b83648516150ec8a99e1b3ace7 in 4msysgit's 'devel' branch now, and will be part of the next msysGit release.

Thanks, Dscho