{"thread":{"id":"18884","subject":"[PATCH] gitk: avoid crash if closed while reading references","startedAt":"2009-04-15T16:14:03Z","lastAt":"2009-04-15T16:46:48Z","messageCount":2,"participants":["Pat Thoyts","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"111368","messageId":"87prfdnbck.fsf@users.sourceforge.net","threadId":"18884","inReplyTo":null,"subject":"[PATCH] gitk: avoid crash if closed while reading references","fromName":"Pat Thoyts","fromEmail":"patthoyts@users.sourceforge.net","sentAt":"2009-04-15T16:14:03Z","receivedAt":"2009-04-15T16:14:03Z","isPatch":true,"sender":{"key":"patthoyts@users.sourceforge.net","avatar":"https://avatars.githubusercontent.com/u/30739?v=4"},"body":"\n  As recorded in msysGit issue 125 if the user closes gitk while it\n  reports itself as still reading references then Tk will crash in the\n  geometry management code. This has been fixed for Tk 8.5.7 and above.\n  This patch avoids the problem by flushing outstanding geometry events\n  before calling the readrefs procedure.\n\n  See also http://code.google.com/p/msysgit/issues/detail?id=125\n\nSigned-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>\n---\n gitk |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/gitk b/gitk\nindex 656c2c1..a346bd5 100755\n--- a/gitk\n+++ b/gitk\n@@ -10952,6 +10952,7 @@ catch {\n # wait for the window to become visible\n tkwait visibility .\n wm title . \"[file tail $argv0]: [file tail [pwd]]\"\n+update\n readrefs\n \n if {$cmdline_files ne {} || $revtreeargs ne {} || $revtreeargscmd ne {}} {\n-- \n1.6.2.2.1669.g7eaf8\n"},{"id":"111373","messageId":"alpine.DEB.1.00.0904151846060.6814@intel-tinevez-2-302","threadId":"18884","inReplyTo":"87prfdnbck.fsf@users.sourceforge.net","subject":"Re: [PATCH] gitk: avoid crash if closed while reading references","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-04-15T16:46:48Z","receivedAt":"2009-04-15T16:46:48Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Wed, 15 Apr 2009, Pat Thoyts wrote:\n\n> \n>   As recorded in msysGit issue 125 if the user closes gitk while it\n>   reports itself as still reading references then Tk will crash in the\n>   geometry management code. This has been fixed for Tk 8.5.7 and above.\n>   This patch avoids the problem by flushing outstanding geometry events\n>   before calling the readrefs procedure.\n> \n>   See also http://code.google.com/p/msysgit/issues/detail?id=125\n> \n> Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>\n\nThis is commit 3d3ecb65e34a62b83648516150ec8a99e1b3ace7 in 4msysgit's \n'devel' branch now, and will be part of the next msysGit release.\n\nThanks,\nDscho\n"}]}