git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitk: avoid crash if closed while reading references

From
Pat Thoyts <patthoyts@users.sourceforge.net>
Date
Apr 15, 2009, 16:14 UTC
Message-ID
<87prfdnbck.fsf@users.sourceforge.net>
  As recorded in msysGit issue 125 if the user closes gitk while it
  reports itself as still reading references then Tk will crash in the
  geometry management code. This has been fixed for Tk 8.5.7 and above.
  This patch avoids the problem by flushing outstanding geometry events
  before calling the readrefs procedure.
  See also http://code.google.com/p/msysgit/issues/detail?id=125
Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
---
 gitk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/gitk b/gitk
index 656c2c1..a346bd5 100755
--- a/gitk
+++ b/gitk
@@ -10952,6 +10952,7 @@ catch {
 # wait for the window to become visible
 tkwait visibility .
 wm title . "[file tail $argv0]: [file tail [pwd]]"
+update
 readrefs
 
 if {$cmdline_files ne {} || $revtreeargs ne {} || $revtreeargscmd ne {}} {
-- 
1.6.2.2.1669.g7eaf8
Next: Johannes Schindelin
Message 1 of 2 in “gitk: avoid crash if closed while reading references”
  1. gitk: avoid crash if closed while reading referencesPat Thoyts, Apr 15, 2009
  2. Johannes SchindelinApr 15, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.