threads / discuss / 18603

[EGIT] How to deal with important modifications

Subject: [EGIT] How to deal with important modifications

## tl;dr

4 messages between Mar 28, 2009 and Mar 30, 2009.

replies: 3people: 4as markdown or json

Yann Simon· Mar 28, 2009, 17:32 UTC · lore

Hi,

I am working on the synchronization view. It is not 100% functional yet. The view is not updated when a local file is modified for example. As the modifications are getting important, I was wondering how to deal with it. Should I continue my work an send all the patches when finished?

To have an overview of the modifications: http://github.com/yanns/egit/commit/18c4a928d53345802a8c9641dcb2d457ebbe2cbc http://github.com/yanns/egit/commit/9fab398fa1b7b6efa9532b3c09e5bcfcc8bb9419

Or should I begin to send patches, but by not activating the function yet? (It could be a way to have other people to help contributing.)

Yann

Ferry Huberts (Pelagic)· Mar 28, 2009, 22:44 UTC · re: Yann Simon · lore

Re: [EGIT] How to deal with important modifications

Yann Simon wrote:

Show 17 quoted lines

> Hi,
> 
> I am working on the synchronization view. It is not 100% functional yet.
> The view is not updated when a local file is modified for example.
> As the modifications are getting important, I was wondering how to deal
> with it. Should I continue my work an send all the patches when
> finished?
> 
> To have an overview of the modifications:
> http://github.com/yanns/egit/commit/18c4a928d53345802a8c9641dcb2d457ebbe2cbc
> http://github.com/yanns/egit/commit/9fab398fa1b7b6efa9532b3c09e5bcfcc8bb9419
> 
> Or should I begin to send patches, but by not activating the function
> yet?
> (It could be a way to have other people to help contributing.)
> 
> Yann

Yann,

I was asking myself the same questions about my work on ignores and chose to send it out early, being half completed. Don't know if that was right, did not receive feedback yet, but it's only been 2 days with Eclipsecon wrapping up on friday.

If you keep a seperate changeset in which you activate your work and split up the changesets in manageable pieces it's easier for others to review your work and comment on it.

Love to see your work though. Having the sync view available for git would be a major plus. I proposed something simpler on the wiki: a 'pending changes' window. But if you have the complete sync view that's wonderful.

my 2 cents  :-)

Ferry

Robin Rosenberg· Mar 29, 2009, 09:45 UTC · re: Ferry Huberts (Pelagic) · lore

Re: [EGIT] How to deal with important modifications

lördag 28 mars 2009 23:44:49 skrev "Ferry Huberts (Pelagic)" <ferry.huberts@pelagic.nl>:

Show 24 quoted lines

> Yann Simon wrote:
> > Hi,
> > 
> > I am working on the synchronization view. It is not 100% functional yet.
> > The view is not updated when a local file is modified for example.
> > As the modifications are getting important, I was wondering how to deal
> > with it. Should I continue my work an send all the patches when
> > finished?
> > 
> > To have an overview of the modifications:
> > http://github.com/yanns/egit/commit/18c4a928d53345802a8c9641dcb2d457ebbe2cbc
> > http://github.com/yanns/egit/commit/9fab398fa1b7b6efa9532b3c09e5bcfcc8bb9419
> > 
> > Or should I begin to send patches, but by not activating the function
> > yet?
> > (It could be a way to have other people to help contributing.)
> > 
> > Yann
> Yann,
> 
> I was asking myself the same questions about my work on ignores and
> chose to send it out early, being half completed. Don't know if that was
> right, did not receive feedback yet, but it's only been 2 days with
> Eclipsecon wrapping up on friday.

That's not the reason you haven't received a response. Basically, the larger a set of patches is, more time is needed.

> If you keep a seperate changeset in which you activate your work and
> split up the changesets in manageable pieces it's easier for others to
> review your work and comment on it.

Indeed. Small patches can be reviewed more quickly if they introduce well defined changes and especially good is if they make sense of their own.

Think about how you would like the changes presented if you were to review them without knowing anything in advance.

-- robin

Shawn O. Pearce· Mar 30, 2009, 04:30 UTC · re: Robin Rosenberg · lore

Re: [EGIT] How to deal with important modifications

Robin Rosenberg <robin.rosenberg.lists@dewire.com> wrote:

Show 9 quoted lines

> l?rdag 28 mars 2009 23:44:49 skrev "Ferry Huberts (Pelagic)" <ferry.huberts@pelagic.nl>:
> > 
> > I was asking myself the same questions about my work on ignores and
> > chose to send it out early, being half completed. Don't know if that was
> > right, did not receive feedback yet, but it's only been 2 days with
> > Eclipsecon wrapping up on friday.
> 
> That's not the reason you haven't received a response. Basically, the larger
> a set of patches is, more time is needed.

Yup.

I plan to block off time to look at the patches tomorrow.

The bigger it is, the more likely it gets pushed off a few days,
until I can block off a seemingly large enough amount of time to
give it a complete reading.

-- 
Shawn.