Re: [EGIT] How to deal with important modifications

From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date: Mar 29, 2009, 09:45 UTC
Message-ID: <200903291145.06135.robin.rosenberg.lists@dewire.com>
In-Reply-To: <49CEA861.4070700@pelagic.nl>

lördag 28 mars 2009 23:44:49 skrev "Ferry Huberts (Pelagic)" <ferry.huberts@pelagic.nl>:

Show 24 quoted lines

> Yann Simon wrote:
> > Hi,
> > 
> > I am working on the synchronization view. It is not 100% functional yet.
> > The view is not updated when a local file is modified for example.
> > As the modifications are getting important, I was wondering how to deal
> > with it. Should I continue my work an send all the patches when
> > finished?
> > 
> > To have an overview of the modifications:
> > http://github.com/yanns/egit/commit/18c4a928d53345802a8c9641dcb2d457ebbe2cbc
> > http://github.com/yanns/egit/commit/9fab398fa1b7b6efa9532b3c09e5bcfcc8bb9419
> > 
> > Or should I begin to send patches, but by not activating the function
> > yet?
> > (It could be a way to have other people to help contributing.)
> > 
> > Yann
> Yann,
> 
> I was asking myself the same questions about my work on ignores and
> chose to send it out early, being half completed. Don't know if that was
> right, did not receive feedback yet, but it's only been 2 days with
> Eclipsecon wrapping up on friday.

That's not the reason you haven't received a response. Basically, the larger a set of patches is, more time is needed.

> If you keep a seperate changeset in which you activate your work and
> split up the changesets in manageable pieces it's easier for others to
> review your work and comment on it.

Indeed. Small patches can be reviewed more quickly if they introduce well defined changes and especially good is if they make sense of their own.

Think about how you would like the changes presented if you were to review them without knowing anything in advance.

-- robin