threads / patch / 18231

patchgit-gui: Append ampersand to Target of lnk files created by do_cygwin_shortcut.

Subject: [PATCH] git-gui: Append ampersand to Target of lnk files created by do_cygwin_shortcut.

## tl;dr

4 messages between Mar 9, 2009 and Mar 9, 2009. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Phil Lawrence· Mar 9, 2009, 17:22 UTC · lore

First post here. First patch, too, so hoping I've invoked git format-patch correctly...

>From 5fddc9b7bfa0dfb8d2c1c0eb59ae9208ff72540d Mon Sep 17 00:00:00 2001
From: Phil Lawrence <prlawrence@gmail.com>
Date: Thu, 5 Mar 2009 17:56:58 -0600
Subject: [PATCH] Append ampersand to Target of lnk files created by
do_cygwin_shortcut.  Allows shell window to close after starting
 Git GUI as a background process.
---
 lib/shortcut.tcl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to lib/shortcut.tcl +1 −2
diff --git a/lib/shortcut.tcl b/lib/shortcut.tcl
index 38c3151..2f20eb3 100644
--- a/lib/shortcut.tcl
+++ b/lib/shortcut.tcl
@@ -54,7 +54,7 @@ proc do_cygwin_shortcut {} {
                                        $argv0]
                                win32_create_lnk $fn [list \
                                        $sh -c \
-                                       "CHERE_INVOKING=1 source
/etc/profile;[sq $me]" \
+                                       "CHERE_INVOKING=1 source
/etc/profile;[sq $me] &" \
                                        ] \
                                        [file dirname [file normalize [gitdir]]]
                        } err]} {
--
1.6.1.9.g97c34

Regards,
Phil Lawrence
Johannes Schindelin· Mar 9, 2009, 20:13 UTC · re: Phil Lawrence · lore

Re: [PATCH] git-gui: Append ampersand to Target of lnk files created by do_cygwin_shortcut.

Hi,
On Mon, 9 Mar 2009, Phil Lawrence wrote:
Show 8 quoted lines
> >From 5fddc9b7bfa0dfb8d2c1c0eb59ae9208ff72540d Mon Sep 17 00:00:00 2001
> From: Phil Lawrence <prlawrence@gmail.com>
> Date: Thu, 5 Mar 2009 17:56:58 -0600
> Subject: [PATCH] Append ampersand to Target of lnk files created by
> do_cygwin_shortcut.  Allows shell window to close after starting
>  Git GUI as a background process.
> 
> ---
A few comments.

Usually we try to use that subject as the subject of the mail, and we also try to keep the subject shorter than 77 characters (so that "git log" on an 80-column display does not need to wrap lines).

Also, we like authors to provide Signed-off-by: lines.

Now, with the technical stuff out of the way: are you not changing behavior? It seems that Linux users expect an program called by a menu item to block the application until the program returns, so that an error can be caught.

Maybe the expectation is different on Windows? But then, we'd still like to catch errors and warn the user about it, right?

Ciao, Dscho

Phil Lawrence· Mar 9, 2009, 20:57 UTC · re: Johannes Schindelin · lore

Re: [PATCH] git-gui: Append ampersand to Target of lnk files created by do_cygwin_shortcut.

On Mon, Mar 9, 2009 at 3:13 PM, Johannes Schindelin wrote:
Show 9 quoted lines
> Hi,
>
> <snip!>
>
> A few comments.
>
> Usually we try to use that subject as the subject of the mail, and we also
> try to keep the subject shorter than 77 characters (so that "git log" on
> an 80-column display does not need to wrap lines).
> Also, we like authors to provide Signed-off-by: lines.
OK, thank you.
> Now, with the technical stuff out of the way: are you not changing
> behavior?  It seems that Linux users expect an program called by a menu
> item to block the application until the program returns, so that an error
> can be caught.

The menu item in question is "Repository | Create Desktop Icon". It does not launch a program, but rather creates a shortcut (.lnk file) on the Windows desktop.

The purpose of the created shortcut is to make it easy for a user to launch git-gui for a particular repo in the future.

> Maybe the expectation is different on Windows?  But then, we'd still like
> to catch errors and warn the user about it, right?

I believe a windows user would expect to see git gui launch when they click the shortcut; they would not expect (nor want) to see a cmd window open and remain open in the background.

msysGit avoids opening a command window altogether when it's Git GUI shortcut is used. Ideally git on cygwin would also have shortcuts that simply open the GUI, but as a first step I saw we could at least make the command window politely disappear.

Phil Lawrence
Johannes Schindelin· Mar 9, 2009, 21:12 UTC · re: Phil Lawrence · lore

Re: [PATCH] git-gui: Append ampersand to Target of lnk files created by do_cygwin_shortcut.

Hi,
On Mon, 9 Mar 2009, Phil Lawrence wrote:
Show 25 quoted lines
> On Mon, Mar 9, 2009 at 3:13 PM, Johannes Schindelin wrote:
>
> > Now, with the technical stuff out of the way: are you not changing 
> > behavior?  It seems that Linux users expect an program called by a 
> > menu item to block the application until the program returns, so that 
> > an error can be caught.
> 
> The menu item in question is "Repository | Create Desktop Icon".  It
> does not launch a program, but rather creates a shortcut (.lnk file)
> on the Windows desktop.
> 
> The purpose of the created shortcut is to make it easy for a user to
> launch git-gui for a particular repo in the future.
> 
> > Maybe the expectation is different on Windows?  But then, we'd still like
> > to catch errors and warn the user about it, right?
> 
> I believe a windows user would expect to see git gui launch when they
> click the shortcut; they would not expect (nor want) to see a cmd
> window open and remain open in the background.
> 
> msysGit avoids opening a command window altogether when it's Git GUI
> shortcut is used.  Ideally git on cygwin would also have shortcuts
> that simply open the GUI, but as a first step I saw we could at least
> make the command window politely disappear.
Thank you!
Could you add those explanations to the commit message?

Thanks, Dscho

← back to recent threads