{"thread":{"id":"18231","subject":"[PATCH] git-gui: Append ampersand to Target of lnk files created by do_cygwin_shortcut.","startedAt":"2009-03-09T17:22:23Z","lastAt":"2009-03-09T21:12:28Z","messageCount":4,"participants":["Phil Lawrence","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"107484","messageId":"530ac78e0903091022s2585231br9ef11d91851250f4@mail.gmail.com","threadId":"18231","inReplyTo":null,"subject":"[PATCH] git-gui: Append ampersand to Target of lnk files created by do_cygwin_shortcut.","fromName":"Phil Lawrence","fromEmail":"prlawrence@gmail.com","sentAt":"2009-03-09T17:22:23Z","receivedAt":"2009-03-09T17:22:23Z","isPatch":true,"sender":{"key":"prlawrence@gmail.com","avatar":"https://gravatar.com/avatar/352044d06dd8919a32522c18c712e0a8d07b8e8719c820b4b50ffb8f6f2fa1f0?d=mp&s=160"},"body":"First post here.  First patch, too, so hoping I've invoked git\nformat-patch correctly...\n\n>From 5fddc9b7bfa0dfb8d2c1c0eb59ae9208ff72540d Mon Sep 17 00:00:00 2001\nFrom: Phil Lawrence <prlawrence@gmail.com>\nDate: Thu, 5 Mar 2009 17:56:58 -0600\nSubject: [PATCH] Append ampersand to Target of lnk files created by\ndo_cygwin_shortcut.  Allows shell window to close after starting\n Git GUI as a background process.\n\n---\n lib/shortcut.tcl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/lib/shortcut.tcl b/lib/shortcut.tcl\nindex 38c3151..2f20eb3 100644\n--- a/lib/shortcut.tcl\n+++ b/lib/shortcut.tcl\n@@ -54,7 +54,7 @@ proc do_cygwin_shortcut {} {\n                                        $argv0]\n                                win32_create_lnk $fn [list \\\n                                        $sh -c \\\n-                                       \"CHERE_INVOKING=1 source\n/etc/profile;[sq $me]\" \\\n+                                       \"CHERE_INVOKING=1 source\n/etc/profile;[sq $me] &\" \\\n                                        ] \\\n                                        [file dirname [file normalize [gitdir]]]\n                        } err]} {\n--\n1.6.1.9.g97c34\n\nRegards,\nPhil Lawrence\n"},{"id":"107496","messageId":"alpine.DEB.1.00.0903092109360.6358@intel-tinevez-2-302","threadId":"18231","inReplyTo":"530ac78e0903091022s2585231br9ef11d91851250f4@mail.gmail.com","subject":"Re: [PATCH] git-gui: Append ampersand to Target of lnk files created by do_cygwin_shortcut.","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-03-09T20:13:24Z","receivedAt":"2009-03-09T20:13:24Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 9 Mar 2009, Phil Lawrence wrote:\n\n> >From 5fddc9b7bfa0dfb8d2c1c0eb59ae9208ff72540d Mon Sep 17 00:00:00 2001\n> From: Phil Lawrence <prlawrence@gmail.com>\n> Date: Thu, 5 Mar 2009 17:56:58 -0600\n> Subject: [PATCH] Append ampersand to Target of lnk files created by\n> do_cygwin_shortcut.  Allows shell window to close after starting\n>  Git GUI as a background process.\n> \n> ---\n\nA few comments.\n\nUsually we try to use that subject as the subject of the mail, and we also \ntry to keep the subject shorter than 77 characters (so that \"git log\" on \nan 80-column display does not need to wrap lines).\n\nAlso, we like authors to provide Signed-off-by: lines.\n\nNow, with the technical stuff out of the way: are you not changing \nbehavior?  It seems that Linux users expect an program called by a menu \nitem to block the application until the program returns, so that an error \ncan be caught.\n\nMaybe the expectation is different on Windows?  But then, we'd still like \nto catch errors and warn the user about it, right?\n\nCiao,\nDscho\n"},{"id":"107503","messageId":"530ac78e0903091357v248895ack63588ae6e5e6b57a@mail.gmail.com","threadId":"18231","inReplyTo":"alpine.DEB.1.00.0903092109360.6358@intel-tinevez-2-302","subject":"Re: [PATCH] git-gui: Append ampersand to Target of lnk files created by do_cygwin_shortcut.","fromName":"Phil Lawrence","fromEmail":"prlawrence@gmail.com","sentAt":"2009-03-09T20:57:16Z","receivedAt":"2009-03-09T20:57:16Z","isPatch":true,"sender":{"key":"prlawrence@gmail.com","avatar":"https://gravatar.com/avatar/352044d06dd8919a32522c18c712e0a8d07b8e8719c820b4b50ffb8f6f2fa1f0?d=mp&s=160"},"body":"On Mon, Mar 9, 2009 at 3:13 PM, Johannes Schindelin wrote:\n> Hi,\n>\n> <snip!>\n>\n> A few comments.\n>\n> Usually we try to use that subject as the subject of the mail, and we also\n> try to keep the subject shorter than 77 characters (so that \"git log\" on\n> an 80-column display does not need to wrap lines).\n\n> Also, we like authors to provide Signed-off-by: lines.\n\nOK, thank you.\n\n> Now, with the technical stuff out of the way: are you not changing\n> behavior?  It seems that Linux users expect an program called by a menu\n> item to block the application until the program returns, so that an error\n> can be caught.\n\nThe menu item in question is \"Repository | Create Desktop Icon\".  It\ndoes not launch a program, but rather creates a shortcut (.lnk file)\non the Windows desktop.\n\nThe purpose of the created shortcut is to make it easy for a user to\nlaunch git-gui for a particular repo in the future.\n\n> Maybe the expectation is different on Windows?  But then, we'd still like\n> to catch errors and warn the user about it, right?\n\nI believe a windows user would expect to see git gui launch when they\nclick the shortcut; they would not expect (nor want) to see a cmd\nwindow open and remain open in the background.\n\nmsysGit avoids opening a command window altogether when it's Git GUI\nshortcut is used.  Ideally git on cygwin would also have shortcuts\nthat simply open the GUI, but as a first step I saw we could at least\nmake the command window politely disappear.\n\nPhil Lawrence\n"},{"id":"107508","messageId":"alpine.DEB.1.00.0903092211230.6358@intel-tinevez-2-302","threadId":"18231","inReplyTo":"530ac78e0903091357v248895ack63588ae6e5e6b57a@mail.gmail.com","subject":"Re: [PATCH] git-gui: Append ampersand to Target of lnk files created by do_cygwin_shortcut.","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2009-03-09T21:12:28Z","receivedAt":"2009-03-09T21:12:28Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 9 Mar 2009, Phil Lawrence wrote:\n\n> On Mon, Mar 9, 2009 at 3:13 PM, Johannes Schindelin wrote:\n>\n> > Now, with the technical stuff out of the way: are you not changing \n> > behavior?  It seems that Linux users expect an program called by a \n> > menu item to block the application until the program returns, so that \n> > an error can be caught.\n> \n> The menu item in question is \"Repository | Create Desktop Icon\".  It\n> does not launch a program, but rather creates a shortcut (.lnk file)\n> on the Windows desktop.\n> \n> The purpose of the created shortcut is to make it easy for a user to\n> launch git-gui for a particular repo in the future.\n> \n> > Maybe the expectation is different on Windows?  But then, we'd still like\n> > to catch errors and warn the user about it, right?\n> \n> I believe a windows user would expect to see git gui launch when they\n> click the shortcut; they would not expect (nor want) to see a cmd\n> window open and remain open in the background.\n> \n> msysGit avoids opening a command window altogether when it's Git GUI\n> shortcut is used.  Ideally git on cygwin would also have shortcuts\n> that simply open the GUI, but as a first step I saw we could at least\n> make the command window politely disappear.\n\nThank you!\n\nCould you add those explanations to the commit message?\n\nThanks,\nDscho\n"}]}