Re: [PATCH] git-gui: Append ampersand to Target of lnk files created by do_cygwin_shortcut.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 9, 2009, 20:13 UTC
Message-ID: <alpine.DEB.1.00.0903092109360.6358@intel-tinevez-2-302>
In-Reply-To: <530ac78e0903091022s2585231br9ef11d91851250f4@mail.gmail.com>

Hi,

On Mon, 9 Mar 2009, Phil Lawrence wrote:

Show 8 quoted lines

> >From 5fddc9b7bfa0dfb8d2c1c0eb59ae9208ff72540d Mon Sep 17 00:00:00 2001
> From: Phil Lawrence <prlawrence@gmail.com>
> Date: Thu, 5 Mar 2009 17:56:58 -0600
> Subject: [PATCH] Append ampersand to Target of lnk files created by
> do_cygwin_shortcut.  Allows shell window to close after starting
>  Git GUI as a background process.
> 
> ---

A few comments.

Usually we try to use that subject as the subject of the mail, and we also try to keep the subject shorter than 77 characters (so that "git log" on an 80-column display does not need to wrap lines).

Also, we like authors to provide Signed-off-by: lines.

Now, with the technical stuff out of the way: are you not changing behavior? It seems that Linux users expect an program called by a menu item to block the application until the program returns, so that an error can be caught.

Maybe the expectation is different on Windows? But then, we'd still like to catch errors and warn the user about it, right?

Ciao, Dscho