threads / patch / 17911

patchadd missing NULL in blame_grep

Subject: [tig PATCH] add missing NULL in blame_grep

## tl;dr

2 messages between Feb 20, 2009 and Feb 20, 2009. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Jeff King· Feb 20, 2009, 03:23 UTC · lore

Commit 436674f introduced a grep_text utility function which takes a NULL-terminated list; the callsite in blame_grep forgot to put in a NULL, leading to segmentation faults.

Signed-off-by: Jeff King <peff@peff.net>
---
 tig.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Show changes to tig.c +1 −0

diff --git a/tig.c b/tig.c
index 5acb398..1de732c 100644
--- a/tig.c
+++ b/tig.c
@@ -4595,6 +4595,7 @@ blame_grep(struct view *view, struct line *line)
 		commit ? commit->id : "",
 		commit && opt_author ? commit->author : "",
 		commit && opt_date ? mkdate(&commit->time) : "",
+		NULL
 	};
 
 	return grep_text(view, text);

-- 
1.6.2.rc1.242.g8d690

Jonas Fonseca· Feb 20, 2009, 14:36 UTC · re: Jeff King · lore

Re: [tig PATCH] add missing NULL in blame_grep

On Fri, Feb 20, 2009 at 04:23, Jeff King <peff@peff.net> wrote:

> Commit 436674f introduced a grep_text utility function which
> takes a NULL-terminated list; the callsite in blame_grep
> forgot to put in a NULL, leading to segmentation faults.

Thanks for bailing me out yet again. :)

-- 
Jonas Fonseca