{"thread":{"id":"17911","subject":"[tig PATCH] add missing NULL in blame_grep","startedAt":"2009-02-20T03:23:43Z","lastAt":"2009-02-20T14:36:15Z","messageCount":2,"participants":["Jeff King","Jonas Fonseca"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"105550","messageId":"20090220032343.GA25022@coredump.intra.peff.net","threadId":"17911","inReplyTo":null,"subject":"[tig PATCH] add missing NULL in blame_grep","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2009-02-20T03:23:43Z","receivedAt":"2009-02-20T03:23:43Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"Commit 436674f introduced a grep_text utility function which\ntakes a NULL-terminated list; the callsite in blame_grep\nforgot to put in a NULL, leading to segmentation faults.\n\nSigned-off-by: Jeff King <peff@peff.net>\n---\n tig.c |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/tig.c b/tig.c\nindex 5acb398..1de732c 100644\n--- a/tig.c\n+++ b/tig.c\n@@ -4595,6 +4595,7 @@ blame_grep(struct view *view, struct line *line)\n \t\tcommit ? commit->id : \"\",\n \t\tcommit && opt_author ? commit->author : \"\",\n \t\tcommit && opt_date ? mkdate(&commit->time) : \"\",\n+\t\tNULL\n \t};\n \n \treturn grep_text(view, text);\n-- \n1.6.2.rc1.242.g8d690\n"},{"id":"105613","messageId":"2c6b72b30902200636xea24fdbs835f683aedab7a6e@mail.gmail.com","threadId":"17911","inReplyTo":"20090220032343.GA25022@coredump.intra.peff.net","subject":"Re: [tig PATCH] add missing NULL in blame_grep","fromName":"Jonas Fonseca","fromEmail":"fonseca@diku.dk","sentAt":"2009-02-20T14:36:15Z","receivedAt":"2009-02-20T14:36:15Z","isPatch":true,"sender":{"key":"fonseca@diku.dk","avatar":"https://gravatar.com/avatar/f82f3ad698717c51873b020c750a92438c820a24056dc39fe4d07baa10a92264?d=mp&s=160"},"body":"On Fri, Feb 20, 2009 at 04:23, Jeff King <peff@peff.net> wrote:\n> Commit 436674f introduced a grep_text utility function which\n> takes a NULL-terminated list; the callsite in blame_grep\n> forgot to put in a NULL, leading to segmentation faults.\n\nThanks for bailing me out yet again. :)\n\n-- \nJonas Fonseca\n"}]}