# [tig PATCH] add missing NULL in blame_grep

2 messages from 2009-02-20 to 2009-02-20. Participants: Jeff King, Jonas Fonseca.
Thread: https://gitlist.dev/t/17911

## Jeff King, 2009-02-20 03:23

Subject: [tig PATCH] add missing NULL in blame_grep
Message-ID: <20090220032343.GA25022@coredump.intra.peff.net>
URL: https://gitlist.dev/e/20090220032343.GA25022%40coredump.intra.peff.net

```
Commit 436674f introduced a grep_text utility function which
takes a NULL-terminated list; the callsite in blame_grep
forgot to put in a NULL, leading to segmentation faults.

Signed-off-by: Jeff King <peff@peff.net>
---
 tig.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/tig.c b/tig.c
index 5acb398..1de732c 100644
--- a/tig.c
+++ b/tig.c
@@ -4595,6 +4595,7 @@ blame_grep(struct view *view, struct line *line)
 		commit ? commit->id : "",
 		commit && opt_author ? commit->author : "",
 		commit && opt_date ? mkdate(&commit->time) : "",
+		NULL
 	};
 
 	return grep_text(view, text);
-- 
1.6.2.rc1.242.g8d690

```

## Jonas Fonseca, 2009-02-20 14:36

Subject: Re: [tig PATCH] add missing NULL in blame_grep
Message-ID: <2c6b72b30902200636xea24fdbs835f683aedab7a6e@mail.gmail.com>
URL: https://gitlist.dev/e/2c6b72b30902200636xea24fdbs835f683aedab7a6e%40mail.gmail.com
In-Reply-To: <20090220032343.GA25022@coredump.intra.peff.net>

```
On Fri, Feb 20, 2009 at 04:23, Jeff King <peff@peff.net> wrote:
> Commit 436674f introduced a grep_text utility function which
> takes a NULL-terminated list; the callsite in blame_grep
> forgot to put in a NULL, leading to segmentation faults.

Thanks for bailing me out yet again. :)

-- 
Jonas Fonseca

```