threads / patch / 16997

patchstgit namelength is an integer

Subject: [PATCH] stgit namelength is an integer

## tl;dr

2 messages between Jan 5, 2009 and Jan 12, 2009. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Pete Wyckoff· Jan 5, 2009, 19:03 UTC · lore

Interpret stgit namelength as an integer, else the use of name_len will fail with

  File "/usr/lib/python2.5/site-packages/stgit/utils.py", line 206, in patch_name_from_msg
    return re.sub('[\W]+', '-', subject_line).strip('-')[:name_len]
TypeError: slice indices must be integers or None or have an __index__ method

Signed-off-by: Pete Wyckoff <pw@padd.com>
---
 stgit/utils.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to stgit/utils.py +1 −1

diff --git a/stgit/utils.py b/stgit/utils.py
index 81035a5..1fa96c2 100644
--- a/stgit/utils.py
+++ b/stgit/utils.py
@@ -215,7 +215,7 @@ def patch_name_from_msg(msg):
     if not msg:
         return None
 
-    name_len = config.get('stgit.namelength')
+    name_len = config.getint('stgit.namelength')
     if not name_len:
         name_len = 30

-- 
1.6.0.6

Karl Hasselström· Jan 12, 2009, 20:13 UTC · re: Pete Wyckoff · lore

Re: [PATCH] stgit namelength is an integer

Thanks, but the test suite fails unless I apply this first:

    Return None instead of crashing on undefined integer config items

    Signed-off-by: Karl Hasselström <kha@treskal.com>

Show changes to stgit/config.py +3 −1

diff --git a/stgit/config.py b/stgit/config.py
index 8934445..5b47580 100644
--- a/stgit/config.py
+++ b/stgit/config.py
@@ -65,7 +65,9 @@ class GitConfig:
 
     def getint(self, name):
         value = self.get(name)
-        if value.isdigit():
+        if value == None:
+            return None
+        elif value.isdigit():
             return int(value)
         else:
             raise GitConfigException, 'Value for "%s" is not an integer: "%s"' % (name, value)

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle