{"thread":{"id":"16997","subject":"[PATCH] stgit namelength is an integer","startedAt":"2009-01-05T19:03:54Z","lastAt":"2009-01-12T20:13:09Z","messageCount":2,"participants":["Pete Wyckoff","Karl Hasselström"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"99376","messageId":"20090105190354.GA8295@osc.edu","threadId":"16997","inReplyTo":null,"subject":"[PATCH] stgit namelength is an integer","fromName":"Pete Wyckoff","fromEmail":"pw@padd.com","sentAt":"2009-01-05T19:03:54Z","receivedAt":"2009-01-05T19:03:54Z","isPatch":true,"sender":{"key":"pw@padd.com","avatar":null},"body":"Interpret stgit namelength as an integer, else the use of\nname_len will fail with\n\n  File \"/usr/lib/python2.5/site-packages/stgit/utils.py\", line 206, in patch_name_from_msg\n    return re.sub('[\\W]+', '-', subject_line).strip('-')[:name_len]\nTypeError: slice indices must be integers or None or have an __index__ method\n\nSigned-off-by: Pete Wyckoff <pw@padd.com>\n---\n stgit/utils.py |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/stgit/utils.py b/stgit/utils.py\nindex 81035a5..1fa96c2 100644\n--- a/stgit/utils.py\n+++ b/stgit/utils.py\n@@ -215,7 +215,7 @@ def patch_name_from_msg(msg):\n     if not msg:\n         return None\n \n-    name_len = config.get('stgit.namelength')\n+    name_len = config.getint('stgit.namelength')\n     if not name_len:\n         name_len = 30\n \n-- \n1.6.0.6\n"},{"id":"100155","messageId":"20090112201309.GA32588@diana.vm.bytemark.co.uk","threadId":"16997","inReplyTo":"20090105190354.GA8295@osc.edu","subject":"Re: [PATCH] stgit namelength is an integer","fromName":"Karl Hasselström","fromEmail":"kha@treskal.com","sentAt":"2009-01-12T20:13:09Z","receivedAt":"2009-01-12T20:13:09Z","isPatch":true,"sender":{"key":"kha@treskal.com","avatar":"https://gravatar.com/avatar/f0120c734b5279b345075a28521e1ac66acb20c9913ffe9bf6ae97e53f7f3f13?d=mp&s=160"},"body":"Thanks, but the test suite fails unless I apply this first:\n\n    Return None instead of crashing on undefined integer config items\n\n    Signed-off-by: Karl Hasselström <kha@treskal.com>\n\ndiff --git a/stgit/config.py b/stgit/config.py\nindex 8934445..5b47580 100644\n--- a/stgit/config.py\n+++ b/stgit/config.py\n@@ -65,7 +65,9 @@ class GitConfig:\n \n     def getint(self, name):\n         value = self.get(name)\n-        if value.isdigit():\n+        if value == None:\n+            return None\n+        elif value.isdigit():\n             return int(value)\n         else:\n             raise GitConfigException, 'Value for \"%s\" is not an integer: \"%s\"' % (name, value)\n\n-- \nKarl Hasselström, kha@treskal.com\n      www.treskal.com/kalle\n"}]}