Re: [PATCH] stgit namelength is an integer

From

Karl Hasselström <kha@treskal.com>

Date

Jan 12, 2009, 20:13 UTC

Message-ID

<20090112201309.GA32588@diana.vm.bytemark.co.uk>

In-Reply-To

<20090105190354.GA8295@osc.edu>

Thanks, but the test suite fails unless I apply this first:

    Return None instead of crashing on undefined integer config items

    Signed-off-by: Karl Hasselström <kha@treskal.com>

diff --git a/stgit/config.py b/stgit/config.py
index 8934445..5b47580 100644
--- a/stgit/config.py
+++ b/stgit/config.py
@@ -65,7 +65,9 @@ class GitConfig:
 
     def getint(self, name):
         value = self.get(name)
-        if value.isdigit():
+        if value == None:
+            return None
+        elif value.isdigit():
             return int(value)
         else:
             raise GitConfigException, 'Value for "%s" is not an integer: "%s"' % (name, value)

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle