threads / discuss / 16990

configure clobbers LDFLAGS

Subject: configure clobbers LDFLAGS

## tl;dr

3 messages between Jan 5, 2009 and Jan 6, 2009.

replies: 2people: 3as markdown or json

Paul Jarc· Jan 5, 2009, 02:27 UTC · lore

(I'm not subscribed; Mail-Followup-To set.)

In a couple of tests, configure clobbers the LDFLAGS value set by the caller. This patch fixes it.

paul

diff --git a/configure.ac b/configure.ac
index 8821b50..0a5fc8c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -127,7 +127,7 @@ else
       SAVE_LDFLAGS="${LDFLAGS}"
       LDFLAGS="${SAVE_LDFLAGS} -Wl,-rpath,/"
       AC_LINK_IFELSE(AC_LANG_PROGRAM([], []), [ld_wl_rpath=yes], [ld_wl_rpath=no])
-      LDFLAGS="${SAVE_LD_FLAGS}"
+      LDFLAGS="${SAVE_LDFLAGS}"
    ])
    if test "$ld_wl_rpath" = "yes"; then
       AC_SUBST(CC_LD_DYNPATH, [-Wl,-rpath,])
@@ -136,7 +136,7 @@ else
          SAVE_LDFLAGS="${LDFLAGS}"
          LDFLAGS="${SAVE_LDFLAGS} -rpath /"
          AC_LINK_IFELSE(AC_LANG_PROGRAM([], []), [ld_rpath=yes], [ld_rpath=no])
-         LDFLAGS="${SAVE_LD_FLAGS}"
+         LDFLAGS="${SAVE_LDFLAGS}"
       ])
       if test "$ld_rpath" = "yes"; then
          AC_SUBST(CC_LD_DYNPATH, [-rpath])

Jeff King· Jan 5, 2009, 06:00 UTC · re: Paul Jarc · lore

Re: configure clobbers LDFLAGS

On Sun, Jan 04, 2009 at 09:27:41PM -0500, Paul Jarc wrote:

> In a couple of tests, configure clobbers the LDFLAGS value set by the
> caller.  This patch fixes it.

Thanks for the patch. It looks obviously correct to me, and the problem was just some typos introduced by 798a9450.

Junio, I think this should go onto maint.

> (I'm not subscribed; Mail-Followup-To set.)

The usual behavior on this list is to reply to the sender, cc'ing the list and any previous to or cc's. So MFT is unnecessary and generally frowned upon here.

Also, if you are planning on sending more patches, the usual practice is for them to be inline rather than attached, with the commit message as the body and any cover letter (like MFT discussion) after the triple-dash; git format-patch will generate this format for you. More information is in Documentation/SubmittingPatches.

-Peff

Junio C Hamano· Jan 6, 2009, 08:19 UTC · re: Jeff King · lore

Re: configure clobbers LDFLAGS

Jeff King <peff@peff.net> writes:

Show 9 quoted lines

> On Sun, Jan 04, 2009 at 09:27:41PM -0500, Paul Jarc wrote:
>
>> In a couple of tests, configure clobbers the LDFLAGS value set by the
>> caller.  This patch fixes it.
>
> Thanks for the patch. It looks obviously correct to me, and the problem
> was just some typos introduced by 798a9450.
>
> Junio, I think this should go onto maint.

Thanks; will queue.