git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: configure clobbers LDFLAGS

From
Jeff King <peff@peff.net>
Date
Jan 5, 2009, 06:00 UTC
Message-ID
<20090105060058.GB13189@coredump.intra.peff.net>
In-Reply-To
<m3tz8e32ru.fsf@multivac.cwru.edu>
On Sun, Jan 04, 2009 at 09:27:41PM -0500, Paul Jarc wrote:
> In a couple of tests, configure clobbers the LDFLAGS value set by the
> caller.  This patch fixes it.

Thanks for the patch. It looks obviously correct to me, and the problem was just some typos introduced by 798a9450.

Junio, I think this should go onto maint.
> (I'm not subscribed; Mail-Followup-To set.)

The usual behavior on this list is to reply to the sender, cc'ing the list and any previous to or cc's. So MFT is unnecessary and generally frowned upon here.

Also, if you are planning on sending more patches, the usual practice is for them to be inline rather than attached, with the commit message as the body and any cover letter (like MFT discussion) after the triple-dash; git format-patch will generate this format for you. More information is in Documentation/SubmittingPatches.

-Peff
Previous: Paul JarcNext: Junio C Hamano
Message 2 of 3 in “configure clobbers LDFLAGS”
  1. Paul JarcJan 5, 2009
  2. Jeff KingJan 5, 2009
  3. Junio C HamanoJan 6, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.