{"thread":{"id":"16990","subject":"configure clobbers LDFLAGS","startedAt":"2009-01-05T02:27:41Z","lastAt":"2009-01-06T08:19:14Z","messageCount":3,"participants":["Paul Jarc","Jeff King","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"99344","messageId":"m3tz8e32ru.fsf@multivac.cwru.edu","threadId":"16990","inReplyTo":null,"subject":"configure clobbers LDFLAGS","fromName":"Paul Jarc","fromEmail":"prj@po.cwru.edu","sentAt":"2009-01-05T02:27:41Z","receivedAt":"2009-01-05T02:27:41Z","isPatch":false,"sender":{"key":"prj@po.cwru.edu","avatar":null},"body":"(I'm not subscribed; Mail-Followup-To set.)\n\nIn a couple of tests, configure clobbers the LDFLAGS value set by the\ncaller.  This patch fixes it.\n\n\npaul\n\n\ndiff --git a/configure.ac b/configure.ac\nindex 8821b50..0a5fc8c 100644\n--- a/configure.ac\n+++ b/configure.ac\n@@ -127,7 +127,7 @@ else\n       SAVE_LDFLAGS=\"${LDFLAGS}\"\n       LDFLAGS=\"${SAVE_LDFLAGS} -Wl,-rpath,/\"\n       AC_LINK_IFELSE(AC_LANG_PROGRAM([], []), [ld_wl_rpath=yes], [ld_wl_rpath=no])\n-      LDFLAGS=\"${SAVE_LD_FLAGS}\"\n+      LDFLAGS=\"${SAVE_LDFLAGS}\"\n    ])\n    if test \"$ld_wl_rpath\" = \"yes\"; then\n       AC_SUBST(CC_LD_DYNPATH, [-Wl,-rpath,])\n@@ -136,7 +136,7 @@ else\n          SAVE_LDFLAGS=\"${LDFLAGS}\"\n          LDFLAGS=\"${SAVE_LDFLAGS} -rpath /\"\n          AC_LINK_IFELSE(AC_LANG_PROGRAM([], []), [ld_rpath=yes], [ld_rpath=no])\n-         LDFLAGS=\"${SAVE_LD_FLAGS}\"\n+         LDFLAGS=\"${SAVE_LDFLAGS}\"\n       ])\n       if test \"$ld_rpath\" = \"yes\"; then\n          AC_SUBST(CC_LD_DYNPATH, [-rpath])\n"},{"id":"99350","messageId":"20090105060058.GB13189@coredump.intra.peff.net","threadId":"16990","inReplyTo":"m3tz8e32ru.fsf@multivac.cwru.edu","subject":"Re: configure clobbers LDFLAGS","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2009-01-05T06:00:58Z","receivedAt":"2009-01-05T06:00:58Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sun, Jan 04, 2009 at 09:27:41PM -0500, Paul Jarc wrote:\n\n> In a couple of tests, configure clobbers the LDFLAGS value set by the\n> caller.  This patch fixes it.\n\nThanks for the patch. It looks obviously correct to me, and the problem\nwas just some typos introduced by 798a9450.\n\nJunio, I think this should go onto maint.\n\n> (I'm not subscribed; Mail-Followup-To set.)\n\nThe usual behavior on this list is to reply to the sender, cc'ing the\nlist and any previous to or cc's. So MFT is unnecessary and generally\nfrowned upon here.\n\nAlso, if you are planning on sending more patches, the usual practice is\nfor them to be inline rather than attached, with the commit message as\nthe body and any cover letter (like MFT discussion) after the\ntriple-dash; git format-patch will generate this format for you.  More\ninformation is in Documentation/SubmittingPatches.\n\n-Peff\n"},{"id":"99443","messageId":"7v1vvgkfst.fsf@gitster.siamese.dyndns.org","threadId":"16990","inReplyTo":"20090105060058.GB13189@coredump.intra.peff.net","subject":"Re: configure clobbers LDFLAGS","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2009-01-06T08:19:14Z","receivedAt":"2009-01-06T08:19:14Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King <peff@peff.net> writes:\n\n> On Sun, Jan 04, 2009 at 09:27:41PM -0500, Paul Jarc wrote:\n>\n>> In a couple of tests, configure clobbers the LDFLAGS value set by the\n>> caller.  This patch fixes it.\n>\n> Thanks for the patch. It looks obviously correct to me, and the problem\n> was just some typos introduced by 798a9450.\n>\n> Junio, I think this should go onto maint.\n\nThanks; will queue.\n"}]}