threads / discuss / 16538

gitk: git bisect view doesn't work

Subject: gitk: git bisect view doesn't work

## tl;dr

4 messages between Dec 1, 2008 and Dec 1, 2008.

replies: 3people: 3as markdown or json

Johannes Sixt· Dec 1, 2008, 14:43 UTC · lore

gitk bails out like this if I do "git bisect view":

$ git bisect start HEAD HEAD~2
Bisecting: 0 revisions left to test after this
[9a61060c7e0d112d0742f5b845210ea8c41b6c6b] Added encoding

$ git bisect view
Error in startup script: can't read "notflag": no such variable
    while executing
"expr {!$notflag}"
    ("--not" arm line 2)
    invoked from within
"switch -glob -- $arg {
            "-d" -
            "--date-order" {
                set vdatemode($n) 1
                # remove from origargs in case we hit an unknown option
                set origarg..."
    (procedure "parseviewargs" line 21)
    invoked from within
"parseviewargs $view $args"
    (procedure "start_rev_list" line 27)
    invoked from within
"start_rev_list $curview"
    (procedure "getcommits" line 5)
    invoked from within
"getcommits {}"
    (file "/usr/local/bin/gitk" line 10897)

$ git version git version 1.6.1.rc1

-- Hannes

Johannes Sixt· Dec 1, 2008, 16:29 UTC · re: Johannes Sixt · lore

Re: gitk: git bisect view doesn't work

Johannes Sixt schrieb:

Show 28 quoted lines

> gitk bails out like this if I do "git bisect view":
> 
> $ git bisect start HEAD HEAD~2
> Bisecting: 0 revisions left to test after this
> [9a61060c7e0d112d0742f5b845210ea8c41b6c6b] Added encoding
> 
> $ git bisect view
> Error in startup script: can't read "notflag": no such variable
>     while executing
> "expr {!$notflag}"
>     ("--not" arm line 2)
>     invoked from within
> "switch -glob -- $arg {
>             "-d" -
>             "--date-order" {
>                 set vdatemode($n) 1
>                 # remove from origargs in case we hit an unknown option
>                 set origarg..."
>     (procedure "parseviewargs" line 21)
>     invoked from within
> "parseviewargs $view $args"
>     (procedure "start_rev_list" line 27)
>     invoked from within
> "start_rev_list $curview"
>     (procedure "getcommits" line 5)
>     invoked from within
> "getcommits {}"
>     (file "/usr/local/bin/gitk" line 10897)

Bisection points to this commit:

commit 2958228430b63f2e38c55519d1f98d8d6d9e23f3
Author: Paul Mackerras <paulus@samba.org>
Date:   Tue Nov 18 19:44:20 2008 +1100

    gitk: Fix switch statement in parseviewargs

-- Hannes

Alexander Gavrilov· Dec 1, 2008, 17:25 UTC · re: Johannes Sixt · lore

[PATCH (GITK FIX)] gitk: Fix the "notflag: no such variable" error in --not processing.

Commit 2958228430b63f2e38c55519d1f98d8d6d9e23f3 fixed the switch statement used in option processing, which made some of the previously unreachable cases executable. This uncovered the fact that the variable used in the handling of the --not option is not initialized.

This patch initializes it. Note that actually it is also possible to remove it completely, because currently nobody uses the value.

Signed-off-by: Alexander Gavrilov <angavrilov@gmail.com>
---

	On Monday 01 December 2008 19:29:53 Johannes Sixt wrote:
	> > $ git bisect view
	> > Error in startup script: can't read "notflag": no such variable
	> >     while executing
	> > "expr {!$notflag}"
	> >     ("--not" arm line 2)
	> >     invoked from within
	> > "switch -glob -- $arg {
	> >             "-d" -
	> >             "--date-order" {
	> >                 set vdatemode($n) 1
	> >                 # remove from origargs in case we hit an unknown option
	> >                 set origarg..."
	> >     (procedure "parseviewargs" line 21)
	> >     invoked from within
	> > "parseviewargs $view $args"
	> >     (procedure "start_rev_list" line 27)
	> >     invoked from within
	> > "start_rev_list $curview"
	> >     (procedure "getcommits" line 5)
	> >     invoked from within
	> > "getcommits {}"
	> >     (file "/usr/local/bin/gitk" line 10897)
	>
	> Bisection points to this commit:
	> 
	> commit 2958228430b63f2e38c55519d1f98d8d6d9e23f3

 gitk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/gitk b/gitk
index f7f1776..6eaeadf 100755
--- a/gitk
+++ b/gitk
@@ -139,6 +139,7 @@ proc parseviewargs {n arglist} {
     set origargs $arglist
     set allknown 1
     set filtered 0
+    set notflag 0
     set i -1
     foreach arg $arglist {
 	incr i

-- 
1.6.0.4.30.gf4240

Paul Mackerras· Dec 1, 2008, 22:45 UTC · re: Alexander Gavrilov · lore

Re: [PATCH (GITK FIX)] gitk: Fix the "notflag: no such variable" error in --not processing.

Alexander Gavrilov writes:

> This patch initializes it. Note that actually it is also possible to
> remove it completely, because currently nobody uses the value.

Thanks.  I actually committed a change to remove it completely.

Paul.