{"thread":{"id":"16538","subject":"gitk: git bisect view doesn't work","startedAt":"2008-12-01T14:43:37Z","lastAt":"2008-12-01T22:45:57Z","messageCount":4,"participants":["Johannes Sixt","Alexander Gavrilov","Paul Mackerras"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"96855","messageId":"4933F819.1010701@viscovery.net","threadId":"16538","inReplyTo":null,"subject":"gitk: git bisect view doesn't work","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2008-12-01T14:43:37Z","receivedAt":"2008-12-01T14:43:37Z","isPatch":false,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"gitk bails out like this if I do \"git bisect view\":\n\n$ git bisect start HEAD HEAD~2\nBisecting: 0 revisions left to test after this\n[9a61060c7e0d112d0742f5b845210ea8c41b6c6b] Added encoding\n\n$ git bisect view\nError in startup script: can't read \"notflag\": no such variable\n while executing\n\"expr {!$notflag}\"\n (\"--not\" arm line 2)\n invoked from within\n\"switch -glob -- $arg {\n \"-d\" -\n \"--date-order\" {\n set vdatemode($n) 1\n # remove from origargs in case we hit an unknown option\n set origarg...\"\n (procedure \"parseviewargs\" line 21)\n invoked from within\n\"parseviewargs $view $args\"\n (procedure \"start_rev_list\" line 27)\n invoked from within\n\"start_rev_list $curview\"\n (procedure \"getcommits\" line 5)\n invoked from within\n\"getcommits {}\"\n (file \"/usr/local/bin/gitk\" line 10897)\n\n$ git version\ngit version 1.6.1.rc1\n\n-- Hannes\n"},{"id":"96865","messageId":"49341101.8050400@viscovery.net","threadId":"16538","inReplyTo":"4933F819.1010701@viscovery.net","subject":"Re: gitk: git bisect view doesn't work","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2008-12-01T16:29:53Z","receivedAt":"2008-12-01T16:29:53Z","isPatch":false,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Johannes Sixt schrieb:\n> gitk bails out like this if I do \"git bisect view\":\n> \n> $ git bisect start HEAD HEAD~2\n> Bisecting: 0 revisions left to test after this\n> [9a61060c7e0d112d0742f5b845210ea8c41b6c6b] Added encoding\n> \n> $ git bisect view\n> Error in startup script: can't read \"notflag\": no such variable\n> while executing\n> \"expr {!$notflag}\"\n> (\"--not\" arm line 2)\n> invoked from within\n> \"switch -glob -- $arg {\n> \"-d\" -\n> \"--date-order\" {\n> set vdatemode($n) 1\n> # remove from origargs in case we hit an unknown option\n> set origarg...\"\n> (procedure \"parseviewargs\" line 21)\n> invoked from within\n> \"parseviewargs $view $args\"\n> (procedure \"start_rev_list\" line 27)\n> invoked from within\n> \"start_rev_list $curview\"\n> (procedure \"getcommits\" line 5)\n> invoked from within\n> \"getcommits {}\"\n> (file \"/usr/local/bin/gitk\" line 10897)\n\nBisection points to this commit:\n\ncommit 2958228430b63f2e38c55519d1f98d8d6d9e23f3\nAuthor: Paul Mackerras \nDate: Tue Nov 18 19:44:20 2008 +1100\n\n gitk: Fix switch statement in parseviewargs\n\n-- Hannes\n"},{"id":"96872","messageId":"200812012025.25286.angavrilov@gmail.com","threadId":"16538","inReplyTo":"49341101.8050400@viscovery.net","subject":"[PATCH (GITK FIX)] gitk: Fix the \"notflag: no such variable\" error in --not processing.","fromName":"Alexander Gavrilov","fromEmail":"angavrilov@gmail.com","sentAt":"2008-12-01T17:25:25Z","receivedAt":"2008-12-01T17:25:25Z","isPatch":true,"sender":{"key":"angavrilov@gmail.com","avatar":"https://avatars.githubusercontent.com/u/42666?v=4"},"body":"Commit 2958228430b63f2e38c55519d1f98d8d6d9e23f3 fixed the\nswitch statement used in option processing, which made some of\nthe previously unreachable cases executable. This uncovered the\nfact that the variable used in the handling of the --not option is not\ninitialized.\n\nThis patch initializes it. Note that actually it is also possible to\nremove it completely, because currently nobody uses the value.\n\nSigned-off-by: Alexander Gavrilov \n---\n\n\tOn Monday 01 December 2008 19:29:53 Johannes Sixt wrote:\n\t> > $ git bisect view\n\t> > Error in startup script: can't read \"notflag\": no such variable\n\t> > while executing\n\t> > \"expr {!$notflag}\"\n\t> > (\"--not\" arm line 2)\n\t> > invoked from within\n\t> > \"switch -glob -- $arg {\n\t> > \"-d\" -\n\t> > \"--date-order\" {\n\t> > set vdatemode($n) 1\n\t> > # remove from origargs in case we hit an unknown option\n\t> > set origarg...\"\n\t> > (procedure \"parseviewargs\" line 21)\n\t> > invoked from within\n\t> > \"parseviewargs $view $args\"\n\t> > (procedure \"start_rev_list\" line 27)\n\t> > invoked from within\n\t> > \"start_rev_list $curview\"\n\t> > (procedure \"getcommits\" line 5)\n\t> > invoked from within\n\t> > \"getcommits {}\"\n\t> > (file \"/usr/local/bin/gitk\" line 10897)\n\t>\n\t> Bisection points to this commit:\n\t> \n\t> commit 2958228430b63f2e38c55519d1f98d8d6d9e23f3\n\n gitk | 1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/gitk b/gitk\nindex f7f1776..6eaeadf 100755\n--- a/gitk\n+++ b/gitk\n@@ -139,6 +139,7 @@ proc parseviewargs {n arglist} {\n set origargs $arglist\n set allknown 1\n set filtered 0\n+ set notflag 0\n set i -1\n foreach arg $arglist {\n \tincr i\n-- \n1.6.0.4.30.gf4240\n"},{"id":"96890","messageId":"18740.26917.872035.57458@cargo.ozlabs.ibm.com","threadId":"16538","inReplyTo":"200812012025.25286.angavrilov@gmail.com","subject":"Re: [PATCH (GITK FIX)] gitk: Fix the \"notflag: no such variable\" error in --not processing.","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2008-12-01T22:45:57Z","receivedAt":"2008-12-01T22:45:57Z","isPatch":true,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"Alexander Gavrilov writes:\n\n> This patch initializes it. Note that actually it is also possible to\n> remove it completely, because currently nobody uses the value.\n\nThanks. I actually committed a change to remove it completely.\n\nPaul.\n"}]}