# gitk: git bisect view doesn't work 4 messages from 2008-12-01 to 2008-12-01. Participants: Johannes Sixt, Alexander Gavrilov, Paul Mackerras. Thread: https://gitlist.dev/t/16538 ## Johannes Sixt, 2008-12-01 14:43 Subject: gitk: git bisect view doesn't work Message-ID: <4933F819.1010701@viscovery.net> URL: https://gitlist.dev/e/4933F819.1010701%40viscovery.net ``` gitk bails out like this if I do "git bisect view": $ git bisect start HEAD HEAD~2 Bisecting: 0 revisions left to test after this [9a61060c7e0d112d0742f5b845210ea8c41b6c6b] Added encoding $ git bisect view Error in startup script: can't read "notflag": no such variable while executing "expr {!$notflag}" ("--not" arm line 2) invoked from within "switch -glob -- $arg { "-d" - "--date-order" { set vdatemode($n) 1 # remove from origargs in case we hit an unknown option set origarg..." (procedure "parseviewargs" line 21) invoked from within "parseviewargs $view $args" (procedure "start_rev_list" line 27) invoked from within "start_rev_list $curview" (procedure "getcommits" line 5) invoked from within "getcommits {}" (file "/usr/local/bin/gitk" line 10897) $ git version git version 1.6.1.rc1 -- Hannes ``` ## Johannes Sixt, 2008-12-01 16:29 Subject: Re: gitk: git bisect view doesn't work Message-ID: <49341101.8050400@viscovery.net> URL: https://gitlist.dev/e/49341101.8050400%40viscovery.net In-Reply-To: <4933F819.1010701@viscovery.net> ``` Johannes Sixt schrieb: > gitk bails out like this if I do "git bisect view": > > $ git bisect start HEAD HEAD~2 > Bisecting: 0 revisions left to test after this > [9a61060c7e0d112d0742f5b845210ea8c41b6c6b] Added encoding > > $ git bisect view > Error in startup script: can't read "notflag": no such variable > while executing > "expr {!$notflag}" > ("--not" arm line 2) > invoked from within > "switch -glob -- $arg { > "-d" - > "--date-order" { > set vdatemode($n) 1 > # remove from origargs in case we hit an unknown option > set origarg..." > (procedure "parseviewargs" line 21) > invoked from within > "parseviewargs $view $args" > (procedure "start_rev_list" line 27) > invoked from within > "start_rev_list $curview" > (procedure "getcommits" line 5) > invoked from within > "getcommits {}" > (file "/usr/local/bin/gitk" line 10897) Bisection points to this commit: commit 2958228430b63f2e38c55519d1f98d8d6d9e23f3 Author: Paul Mackerras Date: Tue Nov 18 19:44:20 2008 +1100 gitk: Fix switch statement in parseviewargs -- Hannes ``` ## Alexander Gavrilov, 2008-12-01 17:25 Subject: [PATCH (GITK FIX)] gitk: Fix the "notflag: no such variable" error in --not processing. Message-ID: <200812012025.25286.angavrilov@gmail.com> URL: https://gitlist.dev/e/200812012025.25286.angavrilov%40gmail.com In-Reply-To: <49341101.8050400@viscovery.net> ``` Commit 2958228430b63f2e38c55519d1f98d8d6d9e23f3 fixed the switch statement used in option processing, which made some of the previously unreachable cases executable. This uncovered the fact that the variable used in the handling of the --not option is not initialized. This patch initializes it. Note that actually it is also possible to remove it completely, because currently nobody uses the value. Signed-off-by: Alexander Gavrilov --- On Monday 01 December 2008 19:29:53 Johannes Sixt wrote: > > $ git bisect view > > Error in startup script: can't read "notflag": no such variable > > while executing > > "expr {!$notflag}" > > ("--not" arm line 2) > > invoked from within > > "switch -glob -- $arg { > > "-d" - > > "--date-order" { > > set vdatemode($n) 1 > > # remove from origargs in case we hit an unknown option > > set origarg..." > > (procedure "parseviewargs" line 21) > > invoked from within > > "parseviewargs $view $args" > > (procedure "start_rev_list" line 27) > > invoked from within > > "start_rev_list $curview" > > (procedure "getcommits" line 5) > > invoked from within > > "getcommits {}" > > (file "/usr/local/bin/gitk" line 10897) > > Bisection points to this commit: > > commit 2958228430b63f2e38c55519d1f98d8d6d9e23f3 gitk | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/gitk b/gitk index f7f1776..6eaeadf 100755 --- a/gitk +++ b/gitk @@ -139,6 +139,7 @@ proc parseviewargs {n arglist} { set origargs $arglist set allknown 1 set filtered 0 + set notflag 0 set i -1 foreach arg $arglist { incr i -- 1.6.0.4.30.gf4240 ``` ## Paul Mackerras, 2008-12-01 22:45 Subject: Re: [PATCH (GITK FIX)] gitk: Fix the "notflag: no such variable" error in --not processing. Message-ID: <18740.26917.872035.57458@cargo.ozlabs.ibm.com> URL: https://gitlist.dev/e/18740.26917.872035.57458%40cargo.ozlabs.ibm.com In-Reply-To: <200812012025.25286.angavrilov@gmail.com> ``` Alexander Gavrilov writes: > This patch initializes it. Note that actually it is also possible to > remove it completely, because currently nobody uses the value. Thanks. I actually committed a change to remove it completely. Paul. ```