threads / patch / 16310

patchgit-gui: Fix the search bar destruction handler.

Subject: [PATCH (GIT-GUI)] git-gui: Fix the search bar destruction handler.

## tl;dr

One message between Nov 13, 2008 and Nov 13, 2008. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Alexander Gavrilov· Nov 13, 2008, 18:52 UTC · lore

Since delete_this is an ordinary function, it should not be passed to cb; otherwise it produces errors when blame windows are closed. Unfortunately, it is not noticeable when blame is shown in the master window, so I missed this bug.

Signed-off-by: Alexander Gavrilov <angavrilov@gmail.com>
---
 lib/search.tcl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to lib/search.tcl +1 −1
diff --git a/lib/search.tcl b/lib/search.tcl
index 32c8656..b371e9a 100644
--- a/lib/search.tcl
+++ b/lib/search.tcl
@@ -35,7 +35,7 @@ constructor new {i_w i_text args} {
 
 	trace add variable searchstring write [cb _incrsearch_cb]
 	
-	bind $w <Destroy> [cb delete_this]
+	bind $w <Destroy> [list delete_this $this]
 	return $this
 }
 
-- 
1.6.0.3.15.gb8d36

← back to recent threads