git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH (GIT-GUI)] git-gui: Fix the search bar destruction handler.

From
Alexander Gavrilov <angavrilov@gmail.com>
Date
Nov 13, 2008, 18:52 UTC
Message-ID
<200811132152.52871.angavrilov@gmail.com>

Since delete_this is an ordinary function, it should not be passed to cb; otherwise it produces errors when blame windows are closed. Unfortunately, it is not noticeable when blame is shown in the master window, so I missed this bug.

Signed-off-by: Alexander Gavrilov <angavrilov@gmail.com>
---
 lib/search.tcl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/search.tcl b/lib/search.tcl
index 32c8656..b371e9a 100644
--- a/lib/search.tcl
+++ b/lib/search.tcl
@@ -35,7 +35,7 @@ constructor new {i_w i_text args} {
 
 	trace add variable searchstring write [cb _incrsearch_cb]
 	
-	bind $w <Destroy> [cb delete_this]
+	bind $w <Destroy> [list delete_this $this]
 	return $this
 }
 
-- 
1.6.0.3.15.gb8d36
Message 1 of 1 in “git-gui: Fix the search bar destruction handler.”
  1. git-gui: Fix the search bar destruction handler.Alexander Gavrilov, Nov 13, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.