{"thread":{"id":"16310","subject":"[PATCH (GIT-GUI)] git-gui: Fix the search bar destruction handler.","startedAt":"2008-11-13T18:52:52Z","lastAt":"2008-11-13T18:52:52Z","messageCount":1,"participants":["Alexander Gavrilov"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"95709","messageId":"200811132152.52871.angavrilov@gmail.com","threadId":"16310","inReplyTo":null,"subject":"[PATCH (GIT-GUI)] git-gui: Fix the search bar destruction handler.","fromName":"Alexander Gavrilov","fromEmail":"angavrilov@gmail.com","sentAt":"2008-11-13T18:52:52Z","receivedAt":"2008-11-13T18:52:52Z","isPatch":true,"sender":{"key":"angavrilov@gmail.com","avatar":"https://avatars.githubusercontent.com/u/42666?v=4"},"body":"Since delete_this is an ordinary function, it\nshould not be passed to cb; otherwise it produces\nerrors when blame windows are closed. Unfortunately,\nit is not noticeable when blame is shown in the\nmaster window, so I missed this bug.\n\nSigned-off-by: Alexander Gavrilov <angavrilov@gmail.com>\n---\n lib/search.tcl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/lib/search.tcl b/lib/search.tcl\nindex 32c8656..b371e9a 100644\n--- a/lib/search.tcl\n+++ b/lib/search.tcl\n@@ -35,7 +35,7 @@ constructor new {i_w i_text args} {\n \n \ttrace add variable searchstring write [cb _incrsearch_cb]\n \t\n-\tbind $w <Destroy> [cb delete_this]\n+\tbind $w <Destroy> [list delete_this $this]\n \treturn $this\n }\n \n-- \n1.6.0.3.15.gb8d36\n"}]}