threads / patch / 16106

patchgit-svn: change dashed git-commit-tree to git commit-tree

Subject: [PATCH] git-svn: change dashed git-commit-tree to git commit-tree

## tl;dr

2 messages between Oct 31, 2008 and Nov 2, 2008. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Deskin Miller· Oct 31, 2008, 04:10 UTC · lore

Signed-off-by: Deskin Miller <deskinm@umich.edu>
---
Once again I'm using a copy of git-svn.perl directly, and this fails to exec.
I looked at it more closely and it fails because git binary calls setup_path,
which puts the libexec path into $PATH; of course, this doesn't happen when
git-svn is called directly.

 git-svn.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to git-svn.perl +1 −1

diff --git a/git-svn.perl b/git-svn.perl
index 2e68c68..56238da 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -2202,7 +2202,7 @@ sub do_git_commit {
 	}
 	die "Tree is not a valid sha1: $tree\n" if $tree !~ /^$::sha1$/o;
 
-	my @exec = ('git-commit-tree', $tree);
+	my @exec = ('git', 'commit-tree', $tree);
 	foreach ($self->get_commit_parents($log_entry)) {
 		push @exec, '-p', $_;
 	}

-- 
1.6.0.3.515.g304f

Eric Wong· Nov 2, 2008, 09:38 UTC · re: Deskin Miller · lore

Re: [PATCH] git-svn: change dashed git-commit-tree to git commit-tree

Deskin Miller <deskinm@umich.edu> wrote:

Show 6 quoted lines

> Signed-off-by: Deskin Miller <deskinm@umich.edu>
> ---
> Once again I'm using a copy of git-svn.perl directly, and this fails to exec.
> I looked at it more closely and it fails because git binary calls setup_path,
> which puts the libexec path into $PATH; of course, this doesn't happen when
> git-svn is called directly.

Thanks Deskin, looks like Junio already picked it up; but if we had git-notes I'd add my Signed-off-by there :)

Also, on the subject of using git-svn.perl directly from the source tree, it may become less usable that way in the near future:

Most of us (myself included) at GitTogether seemed like the idea of splitting git-svn.perl into multiple files for maintainability reasons. I just haven't gotten around to doing it yet.

OTOH, Git.pm is already required (but likely also installed in your normal load paths); so you may just have to remember to use perl -I

-- 
Eric Wong