{"thread":{"id":"16106","subject":"[PATCH] git-svn: change dashed git-commit-tree to git commit-tree","startedAt":"2008-10-31T04:10:25Z","lastAt":"2008-11-02T09:38:58Z","messageCount":2,"participants":["Deskin Miller","Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"94365","messageId":"20081031041025.GB20322@euler","threadId":"16106","inReplyTo":null,"subject":"[PATCH] git-svn: change dashed git-commit-tree to git commit-tree","fromName":"Deskin Miller","fromEmail":"deskinm@umich.edu","sentAt":"2008-10-31T04:10:25Z","receivedAt":"2008-10-31T04:10:25Z","isPatch":true,"sender":{"key":"deskinm@umich.edu","avatar":"https://gravatar.com/avatar/d340a0e612cdf0a79535c71863c0b4c535e9aba63b42032226ae903e638b64f9?d=mp&s=160"},"body":"Signed-off-by: Deskin Miller <deskinm@umich.edu>\n---\nOnce again I'm using a copy of git-svn.perl directly, and this fails to exec.\nI looked at it more closely and it fails because git binary calls setup_path,\nwhich puts the libexec path into $PATH; of course, this doesn't happen when\ngit-svn is called directly.\n\n git-svn.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex 2e68c68..56238da 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -2202,7 +2202,7 @@ sub do_git_commit {\n \t}\n \tdie \"Tree is not a valid sha1: $tree\\n\" if $tree !~ /^$::sha1$/o;\n \n-\tmy @exec = ('git-commit-tree', $tree);\n+\tmy @exec = ('git', 'commit-tree', $tree);\n \tforeach ($self->get_commit_parents($log_entry)) {\n \t\tpush @exec, '-p', $_;\n \t}\n-- \n1.6.0.3.515.g304f\n"},{"id":"94649","messageId":"20081102093858.GA16003@untitled","threadId":"16106","inReplyTo":"20081031041025.GB20322@euler","subject":"Re: [PATCH] git-svn: change dashed git-commit-tree to git commit-tree","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2008-11-02T09:38:58Z","receivedAt":"2008-11-02T09:38:58Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Deskin Miller <deskinm@umich.edu> wrote:\n> Signed-off-by: Deskin Miller <deskinm@umich.edu>\n> ---\n> Once again I'm using a copy of git-svn.perl directly, and this fails to exec.\n> I looked at it more closely and it fails because git binary calls setup_path,\n> which puts the libexec path into $PATH; of course, this doesn't happen when\n> git-svn is called directly.\n\nThanks Deskin, looks like Junio already picked it up; but if we had\ngit-notes I'd add my Signed-off-by there :)\n\n\nAlso, on the subject of using git-svn.perl directly from the source\ntree, it may become less usable that way in the near future:\n\nMost of us (myself included) at GitTogether seemed like the idea of\nsplitting git-svn.perl into multiple files for maintainability reasons.\nI just haven't gotten around to doing it yet.\n\nOTOH, Git.pm is already required (but likely also installed in your\nnormal load paths); so you may just have to remember to use perl -I\n\n-- \nEric Wong\n"}]}