# [PATCH] git-svn: change dashed git-commit-tree to git commit-tree

2 messages from 2008-10-31 to 2008-11-02. Participants: Deskin Miller, Eric Wong.
Thread: https://gitlist.dev/t/16106

## Deskin Miller, 2008-10-31 04:10

Subject: [PATCH] git-svn: change dashed git-commit-tree to git commit-tree
Message-ID: <20081031041025.GB20322@euler>
URL: https://gitlist.dev/e/20081031041025.GB20322%40euler

```
Signed-off-by: Deskin Miller <deskinm@umich.edu>
---
Once again I'm using a copy of git-svn.perl directly, and this fails to exec.
I looked at it more closely and it fails because git binary calls setup_path,
which puts the libexec path into $PATH; of course, this doesn't happen when
git-svn is called directly.

 git-svn.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-svn.perl b/git-svn.perl
index 2e68c68..56238da 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -2202,7 +2202,7 @@ sub do_git_commit {
 	}
 	die "Tree is not a valid sha1: $tree\n" if $tree !~ /^$::sha1$/o;
 
-	my @exec = ('git-commit-tree', $tree);
+	my @exec = ('git', 'commit-tree', $tree);
 	foreach ($self->get_commit_parents($log_entry)) {
 		push @exec, '-p', $_;
 	}
-- 
1.6.0.3.515.g304f

```

## Eric Wong, 2008-11-02 09:38

Subject: Re: [PATCH] git-svn: change dashed git-commit-tree to git commit-tree
Message-ID: <20081102093858.GA16003@untitled>
URL: https://gitlist.dev/e/20081102093858.GA16003%40untitled
In-Reply-To: <20081031041025.GB20322@euler>

```
Deskin Miller <deskinm@umich.edu> wrote:
> Signed-off-by: Deskin Miller <deskinm@umich.edu>
> ---
> Once again I'm using a copy of git-svn.perl directly, and this fails to exec.
> I looked at it more closely and it fails because git binary calls setup_path,
> which puts the libexec path into $PATH; of course, this doesn't happen when
> git-svn is called directly.

Thanks Deskin, looks like Junio already picked it up; but if we had
git-notes I'd add my Signed-off-by there :)


Also, on the subject of using git-svn.perl directly from the source
tree, it may become less usable that way in the near future:

Most of us (myself included) at GitTogether seemed like the idea of
splitting git-svn.perl into multiple files for maintainability reasons.
I just haven't gotten around to doing it yet.

OTOH, Git.pm is already required (but likely also installed in your
normal load paths); so you may just have to remember to use perl -I

-- 
Eric Wong

```