threads / patch / 15047

patch, 6 partsDisable IPv6 support for Haiku

Subject: [PATCH 1/6] Disable IPv6 support for Haiku

## tl;dr

4 messages between Aug 17, 2008 and Aug 18, 2008. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Andreas Färber· Aug 17, 2008, 08:56 UTC · lore
Signed-off-by: Andreas Faerber <andreas.faerber@web.de>
Acked-by: Ingo Weinhold <ingo_weinhold@gmx.de>
Acked-by: Scott McCreary <scottmc2@gmail.com>
---
  Makefile |    3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)
Show changes to Makefile +3 −0
diff --git a/Makefile b/Makefile
index 53ab4b5..b22dbcf 100644
--- a/Makefile
+++ b/Makefile
@@ -728,6 +728,9 @@ ifeq ($(uname_S),HP-UX)
  	NO_HSTRERROR = YesPlease
  	NO_SYS_SELECT_H = YesPlease
  endif
+ifeq ($(uname_S),Haiku)
+	NO_IPV6 = YesPlease
+endif
  ifneq (,$(findstring MINGW,$(uname_S)))
  	NO_MMAP = YesPlease
  	NO_PREAD = YesPlease

-- 
1.6.0.rc3.32.g8aaa
Alex Riesen· Aug 17, 2008, 20:33 UTC · re: Andreas Färber · lore

Re: [PATCH 1/6] Disable IPv6 support for Haiku

Andreas Färber, Sun, Aug 17, 2008 10:56:56 +0200:
> +ifeq ($(uname_S),Haiku)
> +	NO_IPV6 = YesPlease
> +endif

Does Haiku have no IPv6 support at all, or it is just the getaddrinfo and the like functions which are missing?

Andreas Färber· Aug 18, 2008, 17:23 UTC · re: Alex Riesen · lore

Re: [PATCH 1/6] Disable IPv6 support for Haiku

Am 17.08.2008 um 22:33 schrieb Alex Riesen:
Show 7 quoted lines
> Andreas Färber, Sun, Aug 17, 2008 10:56:56 +0200:
>> +ifeq ($(uname_S),Haiku)
>> +	NO_IPV6 = YesPlease
>> +endif
>
> Does Haiku have no IPv6 support at all, or it is just the getaddrinfo
> and the like functions which are missing?

Haiku does not yet have complete IPv6 support afaik (would've been a GSoC project), it does have getaddrinfo though. Not setting NO_IPV6 currently leads to compilation errors (redefinition of struct sockaddr_in), I assume that should be fixed on their side of things.

In the current series of patches I had not included a check for libnetwork in configure.ac, so that getaddrinfo does not get detected. Would you prefer to have it already detected, but to override it via the above Makefile line? (That works as well.) Or to have it detected but have the user manually pass NO_IPV6=YesPlease to avoid a future revert of that line?

Andreas
Alex Riesen· Aug 18, 2008, 20:04 UTC · re: Andreas Färber · lore

Re: [PATCH 1/6] Disable IPv6 support for Haiku

Andreas Färber, Mon, Aug 18, 2008 19:23:35 +0200:
Show 13 quoted lines
> Am 17.08.2008 um 22:33 schrieb Alex Riesen:
>> Andreas Färber, Sun, Aug 17, 2008 10:56:56 +0200:
>>> +ifeq ($(uname_S),Haiku)
>>> +	NO_IPV6 = YesPlease
>>> +endif
>>
>> Does Haiku have no IPv6 support at all, or it is just the getaddrinfo
>> and the like functions which are missing?
>
> Haiku does not yet have complete IPv6 support afaik (would've been a  
> GSoC project), it does have getaddrinfo though. Not setting NO_IPV6  
> currently leads to compilation errors (redefinition of struct  
> sockaddr_in), I assume that should be fixed on their side of things.
Ah, that's what it was...
Show 6 quoted lines
> In the current series of patches I had not included a check for  
> libnetwork in configure.ac, so that getaddrinfo does not get detected.  
> Would you prefer to have it already detected, but to override it via the 
> above Makefile line? (That works as well.) Or to have it detected but 
> have the user manually pass NO_IPV6=YesPlease to avoid a future revert of 
> that line?

I think your patch as-is will be preferred (it just works). It is not a big deal to change it later.

← back to recent threads