Re: [PATCH 1/6] Disable IPv6 support for Haiku

From: Alex Riesen <raa.lkml@gmail.com>
Date: Aug 18, 2008, 20:04 UTC
Message-ID: <20080818200429.GD3262@steel.home>
In-Reply-To: <795912D9-BAA1-4E42-A533-435CB1BCCCAC@web.de>

Andreas Färber, Mon, Aug 18, 2008 19:23:35 +0200:

Show 13 quoted lines

> Am 17.08.2008 um 22:33 schrieb Alex Riesen:
>> Andreas Färber, Sun, Aug 17, 2008 10:56:56 +0200:
>>> +ifeq ($(uname_S),Haiku)
>>> +	NO_IPV6 = YesPlease
>>> +endif
>>
>> Does Haiku have no IPv6 support at all, or it is just the getaddrinfo
>> and the like functions which are missing?
>
> Haiku does not yet have complete IPv6 support afaik (would've been a  
> GSoC project), it does have getaddrinfo though. Not setting NO_IPV6  
> currently leads to compilation errors (redefinition of struct  
> sockaddr_in), I assume that should be fixed on their side of things.

Ah, that's what it was...

Show 6 quoted lines

> In the current series of patches I had not included a check for  
> libnetwork in configure.ac, so that getaddrinfo does not get detected.  
> Would you prefer to have it already detected, but to override it via the 
> above Makefile line? (That works as well.) Or to have it detected but 
> have the user manually pass NO_IPV6=YesPlease to avoid a future revert of 
> that line?

I think your patch as-is will be preferred (it just works). It is not a big deal to change it later.