{"thread":{"id":"15047","subject":"[PATCH 1/6] Disable IPv6 support for Haiku","startedAt":"2008-08-17T08:56:56Z","lastAt":"2008-08-18T20:04:29Z","messageCount":4,"participants":["Andreas Färber","Alex Riesen"],"isPatch":true,"patchVersion":1,"patchTotal":6},"messages":[{"id":"87415","messageId":"7CCFCB0B-382F-4A94-B8A7-796156A73CEF@web.de","threadId":"15047","inReplyTo":null,"subject":"[PATCH 1/6] Disable IPv6 support for Haiku","fromName":"Andreas Färber","fromEmail":"andreas.faerber@web.de","sentAt":"2008-08-17T08:56:56Z","receivedAt":"2008-08-17T08:56:56Z","isPatch":true,"sender":{"key":"andreas.faerber@web.de","avatar":"https://gravatar.com/avatar/ac719235a76c4a5e248080fee1f7b6f507bdb1f3d71f7ae48457f3ead91ed1c0?d=mp&s=160"},"body":"Signed-off-by: Andreas Faerber \nAcked-by: Ingo Weinhold \nAcked-by: Scott McCreary \n---\n Makefile | 3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 53ab4b5..b22dbcf 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -728,6 +728,9 @@ ifeq ($(uname_S),HP-UX)\n \tNO_HSTRERROR = YesPlease\n \tNO_SYS_SELECT_H = YesPlease\n endif\n+ifeq ($(uname_S),Haiku)\n+\tNO_IPV6 = YesPlease\n+endif\n ifneq (,$(findstring MINGW,$(uname_S)))\n \tNO_MMAP = YesPlease\n \tNO_PREAD = YesPlease\n-- \n1.6.0.rc3.32.g8aaa\n"},{"id":"87460","messageId":"20080817203335.GB6366@steel.home","threadId":"15047","inReplyTo":"7CCFCB0B-382F-4A94-B8A7-796156A73CEF@web.de","subject":"Re: [PATCH 1/6] Disable IPv6 support for Haiku","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2008-08-17T20:33:35Z","receivedAt":"2008-08-17T20:33:35Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Andreas Färber, Sun, Aug 17, 2008 10:56:56 +0200:\n> +ifeq ($(uname_S),Haiku)\n> +\tNO_IPV6 = YesPlease\n> +endif\n\nDoes Haiku have no IPv6 support at all, or it is just the getaddrinfo\nand the like functions which are missing?\n"},{"id":"87550","messageId":"795912D9-BAA1-4E42-A533-435CB1BCCCAC@web.de","threadId":"15047","inReplyTo":"20080817203335.GB6366@steel.home","subject":"Re: [PATCH 1/6] Disable IPv6 support for Haiku","fromName":"Andreas Färber","fromEmail":"andreas.faerber@web.de","sentAt":"2008-08-18T17:23:35Z","receivedAt":"2008-08-18T17:23:35Z","isPatch":true,"sender":{"key":"andreas.faerber@web.de","avatar":"https://gravatar.com/avatar/ac719235a76c4a5e248080fee1f7b6f507bdb1f3d71f7ae48457f3ead91ed1c0?d=mp&s=160"},"body":"\nAm 17.08.2008 um 22:33 schrieb Alex Riesen:\n\n> Andreas Färber, Sun, Aug 17, 2008 10:56:56 +0200:\n>> +ifeq ($(uname_S),Haiku)\n>> +\tNO_IPV6 = YesPlease\n>> +endif\n>\n> Does Haiku have no IPv6 support at all, or it is just the getaddrinfo\n> and the like functions which are missing?\n\nHaiku does not yet have complete IPv6 support afaik (would've been a \nGSoC project), it does have getaddrinfo though. Not setting NO_IPV6 \ncurrently leads to compilation errors (redefinition of struct \nsockaddr_in), I assume that should be fixed on their side of things.\n\nIn the current series of patches I had not included a check for \nlibnetwork in configure.ac, so that getaddrinfo does not get detected. \nWould you prefer to have it already detected, but to override it via \nthe above Makefile line? (That works as well.) Or to have it detected \nbut have the user manually pass NO_IPV6=YesPlease to avoid a future \nrevert of that line?\n\nAndreas\n"},{"id":"87566","messageId":"20080818200429.GD3262@steel.home","threadId":"15047","inReplyTo":"795912D9-BAA1-4E42-A533-435CB1BCCCAC@web.de","subject":"Re: [PATCH 1/6] Disable IPv6 support for Haiku","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2008-08-18T20:04:29Z","receivedAt":"2008-08-18T20:04:29Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Andreas Färber, Mon, Aug 18, 2008 19:23:35 +0200:\n> Am 17.08.2008 um 22:33 schrieb Alex Riesen:\n>> Andreas Färber, Sun, Aug 17, 2008 10:56:56 +0200:\n>>> +ifeq ($(uname_S),Haiku)\n>>> +\tNO_IPV6 = YesPlease\n>>> +endif\n>>\n>> Does Haiku have no IPv6 support at all, or it is just the getaddrinfo\n>> and the like functions which are missing?\n>\n> Haiku does not yet have complete IPv6 support afaik (would've been a \n> GSoC project), it does have getaddrinfo though. Not setting NO_IPV6 \n> currently leads to compilation errors (redefinition of struct \n> sockaddr_in), I assume that should be fixed on their side of things.\n\nAh, that's what it was...\n\n> In the current series of patches I had not included a check for \n> libnetwork in configure.ac, so that getaddrinfo does not get detected. \n> Would you prefer to have it already detected, but to override it via the \n> above Makefile line? (That works as well.) Or to have it detected but \n> have the user manually pass NO_IPV6=YesPlease to avoid a future revert of \n> that line?\n\nI think your patch as-is will be preferred (it just works).\nIt is not a big deal to change it later.\n"}]}