threads / patch / 15017

patchFix t3700 on filesystems which do not support question marks in names

Subject: [PATCH] Fix t3700 on filesystems which do not support question marks in names

## tl;dr

7 messages between Aug 15, 2008 and Aug 15, 2008. Diffs are folded; open one to read it.

replies: 6people: 3as markdown or json

Alex Riesen· Aug 15, 2008, 07:11 UTC · lore

And the prominent example of the deficiency are, as usual, the filesystems of Microsoft house.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
 t/t3700-add.sh |   19 ++++++++++++-------
 1 files changed, 12 insertions(+), 7 deletions(-)
From 2e5bbfea6a3ee6ff8cf82599cec0e49de94d0631 Mon Sep 17 00:00:00 2001
From: Alex Riesen <raa.lkml@gmail.com>
Date: Fri, 15 Aug 2008 09:00:54 +0200
Subject: [PATCH] Fix t3700 on filesystems which do not support question marks in names

And the prominent example of the deficiency are, as usual, the filesystems of Microsoft house.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
 t/t3700-add.sh |   19 ++++++++++++-------
 1 files changed, 12 insertions(+), 7 deletions(-)
Show changes to t/t3700-add.sh +12 −7
diff --git a/t/t3700-add.sh b/t/t3700-add.sh
index 77a782c..2fa907e 100755
--- a/t/t3700-add.sh
+++ b/t/t3700-add.sh
@@ -222,12 +222,17 @@ test_expect_success 'git add (add.ignore-errors = false)' '
 	! ( git ls-files foo1 | grep foo1 )
 '
 
-test_expect_success 'git add '\''fo\?bar'\'' ignores foobar' '
-	git reset --hard &&
-	touch fo\?bar foobar &&
-	git add '\''fo\?bar'\'' &&
-	git ls-files fo\?bar | grep -F fo\?bar &&
-	! ( git ls-files foobar | grep foobar )
-'
+if touch fo\?bar
+then
+	test_expect_success 'git add '\''fo\?bar'\'' ignores foobar' '
+		git reset --hard &&
+		touch foobar &&
+		git add '\''fo\?bar'\'' &&
+		git ls-files fo\?bar | grep -F fo\?bar &&
+		! ( git ls-files foobar | grep foobar )
+	'
+else
+	say "The filesystem does not support ? in names, some tests skipped"
+fi
 
 test_done

-- 
1.6.0.rc2.68.g49fa3
Junio C Hamano· Aug 15, 2008, 07:17 UTC · re: Alex Riesen · lore

Re: [PATCH] Fix t3700 on filesystems which do not support question marks in names

"Alex Riesen" <raa.lkml@gmail.com> writes:
Show 15 quoted lines
> And the prominent example of the deficiency are, as usual, the filesystems
> of Microsoft house.
>
> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> ---
>  t/t3700-add.sh |   19 ++++++++++++-------
>  1 files changed, 12 insertions(+), 7 deletions(-)
>
> From 2e5bbfea6a3ee6ff8cf82599cec0e49de94d0631 Mon Sep 17 00:00:00 2001
> From: Alex Riesen <raa.lkml@gmail.com>
> Date: Fri, 15 Aug 2008 09:00:54 +0200
> Subject: [PATCH] Fix t3700 on filesystems which do not support question marks in names
>
> And the prominent example of the deficiency are, as usual, the filesystems
> of Microsoft house.

Can other glob specials such as '*' or '[' be used instead of skipping the test?

Alex Riesen· Aug 15, 2008, 07:23 UTC · re: Junio C Hamano · lore

Re: [PATCH] Fix t3700 on filesystems which do not support question marks in names

2008/8/15 Junio C Hamano <gitster@pobox.com>:
Show 5 quoted lines
>> And the prominent example of the deficiency are, as usual, the filesystems
>> of Microsoft house.
>
> Can other glob specials such as '*' or '[' be used instead of skipping the
> test?
Ah... The brackets are allowed.
Alex Riesen· Aug 15, 2008, 07:32 UTC · re: Alex Riesen · lore
Use square brackets instead.

And the prominent example of the deficiency are, as usual, the filesystems of Microsoft house.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
2008/8/15 Junio C Hamano <gitster@pobox.com>:
Show 7 quoted lines
>>> And the prominent example of the deficiency are, as usual, the filesystems
>>> of Microsoft house.
>>
>> Can other glob specials such as '*' or '[' be used instead of skipping the
>> test?
>
> Ah... The brackets are allowed.
Sorry, should have thought of it.
 t/t3700-add.sh |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
From 3a25527fa61463d5968586efa1f3474008bbe2d4 Mon Sep 17 00:00:00 2001
From: Alex Riesen <raa.lkml@gmail.com>
Date: Fri, 15 Aug 2008 09:00:54 +0200
Subject: [PATCH] Fix t3700 on filesystems which do not support question marks in names
Use square brackets instead.

And the prominent example of the deficiency are, as usual, the filesystems of Microsoft house.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
 t/t3700-add.sh |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
Show changes to t/t3700-add.sh +4 −4
diff --git a/t/t3700-add.sh b/t/t3700-add.sh
index 77a782c..2ac93a3 100755
--- a/t/t3700-add.sh
+++ b/t/t3700-add.sh
@@ -222,11 +222,11 @@ test_expect_success 'git add (add.ignore-errors = false)' '
 	! ( git ls-files foo1 | grep foo1 )
 '
 
-test_expect_success 'git add '\''fo\?bar'\'' ignores foobar' '
+test_expect_success 'git add '\''fo\[ou\]bar'\'' ignores foobar' '
 	git reset --hard &&
-	touch fo\?bar foobar &&
-	git add '\''fo\?bar'\'' &&
-	git ls-files fo\?bar | grep -F fo\?bar &&
+	touch fo\[ou\]bar foobar &&
+	git add '\''fo\[ou\]bar'\'' &&
+	git ls-files fo\[ou\]bar | grep -F fo\[ou\]bar &&
 	! ( git ls-files foobar | grep foobar )
 '
 

-- 
1.6.0.rc2.68.g49fa3
Kevin Ballard· Aug 15, 2008, 08:23 UTC · re: Alex Riesen · lore

Re: [PATCH] Fix t3700 on filesystems which do not support question marks in names

Wow, trying to use git-am to apply this patch bus errors. This isn't good. Specifically, git mailinfo bus errors when the email is piped to it. Curiously, the attached "patch" is actually another MIME-formatted message with an inline patch. And I can pipe this "patch" to git-am and that works. How did you generate this message?

In any case, the patch looks good to me.
Signed-off-by: Kevin Ballard <kevin@sb.org>
-Kevin Ballard
On Aug 15, 2008, at 12:32 AM, Alex Riesen wrote:
Show 25 quoted lines
> Use square brackets instead.
>
> And the prominent example of the deficiency are, as usual, the  
> filesystems
> of Microsoft house.
>
> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> ---
>
> 2008/8/15 Junio C Hamano <gitster@pobox.com>:
>>>> And the prominent example of the deficiency are, as usual, the  
>>>> filesystems
>>>> of Microsoft house.
>>>
>>> Can other glob specials such as '*' or '[' be used instead of  
>>> skipping the
>>> test?
>>
>> Ah... The brackets are allowed.
>
> Sorry, should have thought of it.
>
> t/t3700-add.sh |    8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
> <0001-Fix-t3700-on-filesystems-which-do-not-support-questi.patch>
-- 
Kevin Ballard
http://kevin.sb.org
kevin@sb.org
http://www.tildesoft.com
Kevin Ballard· Aug 15, 2008, 08:30 UTC · re: Kevin Ballard · lore

Re: [PATCH] Fix t3700 on filesystems which do not support question marks in names

On Aug 15, 2008, at 1:23 AM, Kevin Ballard wrote:
Show 5 quoted lines
> Wow, trying to use git-am to apply this patch bus errors. This isn't  
> good. Specifically, git mailinfo bus errors when the email is piped  
> to it. Curiously, the attached "patch" is actually another MIME- 
> formatted message with an inline patch. And I can pipe this "patch"  
> to git-am and that works. How did you generate this message?

Ok, it turns out that Don Zickus's patch "Allow emails with boundaries to work again [v2]" fixes the crash.

-Kevin Ballard
-- 
Kevin Ballard
http://kevin.sb.org
kevin@sb.org
http://www.tildesoft.com

← back to recent threads