{"thread":{"id":"15017","subject":"[PATCH] Fix t3700 on filesystems which do not support question marks in names","startedAt":"2008-08-15T07:11:23Z","lastAt":"2008-08-15T09:01:01Z","messageCount":7,"participants":["Alex Riesen","Junio C Hamano","Kevin Ballard"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"87292","messageId":"81b0412b0808150011r534d8453yab2a5c42b255657f@mail.gmail.com","threadId":"15017","inReplyTo":null,"subject":"[PATCH] Fix t3700 on filesystems which do not support question marks in names","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2008-08-15T07:11:23Z","receivedAt":"2008-08-15T07:11:23Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"And the prominent example of the deficiency are, as usual, the filesystems\nof Microsoft house.\n\nSigned-off-by: Alex Riesen \n---\n t/t3700-add.sh | 19 ++++++++++++-------\n 1 files changed, 12 insertions(+), 7 deletions(-)\n\n\nFrom 2e5bbfea6a3ee6ff8cf82599cec0e49de94d0631 Mon Sep 17 00:00:00 2001\nFrom: Alex Riesen \nDate: Fri, 15 Aug 2008 09:00:54 +0200\nSubject: [PATCH] Fix t3700 on filesystems which do not support question marks in names\n\nAnd the prominent example of the deficiency are, as usual, the filesystems\nof Microsoft house.\n\nSigned-off-by: Alex Riesen \n---\n t/t3700-add.sh | 19 ++++++++++++-------\n 1 files changed, 12 insertions(+), 7 deletions(-)\n\ndiff --git a/t/t3700-add.sh b/t/t3700-add.sh\nindex 77a782c..2fa907e 100755\n--- a/t/t3700-add.sh\n+++ b/t/t3700-add.sh\n@@ -222,12 +222,17 @@ test_expect_success 'git add (add.ignore-errors = false)' '\n \t! ( git ls-files foo1 | grep foo1 )\n '\n \n-test_expect_success 'git add '\\''fo\\?bar'\\'' ignores foobar' '\n-\tgit reset --hard &&\n-\ttouch fo\\?bar foobar &&\n-\tgit add '\\''fo\\?bar'\\'' &&\n-\tgit ls-files fo\\?bar | grep -F fo\\?bar &&\n-\t! ( git ls-files foobar | grep foobar )\n-'\n+if touch fo\\?bar\n+then\n+\ttest_expect_success 'git add '\\''fo\\?bar'\\'' ignores foobar' '\n+\t\tgit reset --hard &&\n+\t\ttouch foobar &&\n+\t\tgit add '\\''fo\\?bar'\\'' &&\n+\t\tgit ls-files fo\\?bar | grep -F fo\\?bar &&\n+\t\t! ( git ls-files foobar | grep foobar )\n+\t'\n+else\n+\tsay \"The filesystem does not support ? in names, some tests skipped\"\n+fi\n \n test_done\n-- \n1.6.0.rc2.68.g49fa3\n\n"},{"id":"87293","messageId":"7vproabvcr.fsf@gitster.siamese.dyndns.org","threadId":"15017","inReplyTo":"81b0412b0808150011r534d8453yab2a5c42b255657f@mail.gmail.com","subject":"Re: [PATCH] Fix t3700 on filesystems which do not support question marks in names","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-08-15T07:17:24Z","receivedAt":"2008-08-15T07:17:24Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Alex Riesen\" writes:\n\n> And the prominent example of the deficiency are, as usual, the filesystems\n> of Microsoft house.\n>\n> Signed-off-by: Alex Riesen \n> ---\n> t/t3700-add.sh | 19 ++++++++++++-------\n> 1 files changed, 12 insertions(+), 7 deletions(-)\n>\n> From 2e5bbfea6a3ee6ff8cf82599cec0e49de94d0631 Mon Sep 17 00:00:00 2001\n> From: Alex Riesen \n> Date: Fri, 15 Aug 2008 09:00:54 +0200\n> Subject: [PATCH] Fix t3700 on filesystems which do not support question marks in names\n>\n> And the prominent example of the deficiency are, as usual, the filesystems\n> of Microsoft house.\n\nCan other glob specials such as '*' or '[' be used instead of skipping the\ntest?\n"},{"id":"87294","messageId":"81b0412b0808150023sd30559fi68ff1e439013f26e@mail.gmail.com","threadId":"15017","inReplyTo":"7vproabvcr.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] Fix t3700 on filesystems which do not support question marks in names","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2008-08-15T07:23:09Z","receivedAt":"2008-08-15T07:23:09Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"2008/8/15 Junio C Hamano :\n>> And the prominent example of the deficiency are, as usual, the filesystems\n>> of Microsoft house.\n>\n> Can other glob specials such as '*' or '[' be used instead of skipping the\n> test?\n\nAh... The brackets are allowed.\n"},{"id":"87295","messageId":"81b0412b0808150032o20f69346jb4f573b78cd11f2b@mail.gmail.com","threadId":"15017","inReplyTo":"81b0412b0808150023sd30559fi68ff1e439013f26e@mail.gmail.com","subject":"[PATCH] Fix t3700 on filesystems which do not support question marks in names","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2008-08-15T07:32:30Z","receivedAt":"2008-08-15T07:32:30Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Use square brackets instead.\n\nAnd the prominent example of the deficiency are, as usual, the filesystems\nof Microsoft house.\n\nSigned-off-by: Alex Riesen \n---\n\n2008/8/15 Junio C Hamano :\n>>> And the prominent example of the deficiency are, as usual, the filesystems\n>>> of Microsoft house.\n>>\n>> Can other glob specials such as '*' or '[' be used instead of skipping the\n>> test?\n>\n> Ah... The brackets are allowed.\n\nSorry, should have thought of it.\n\n t/t3700-add.sh | 8 ++++----\n 1 files changed, 4 insertions(+), 4 deletions(-)\n\n\nFrom 3a25527fa61463d5968586efa1f3474008bbe2d4 Mon Sep 17 00:00:00 2001\nFrom: Alex Riesen \nDate: Fri, 15 Aug 2008 09:00:54 +0200\nSubject: [PATCH] Fix t3700 on filesystems which do not support question marks in names\n\nUse square brackets instead.\n\nAnd the prominent example of the deficiency are, as usual, the filesystems\nof Microsoft house.\n\nSigned-off-by: Alex Riesen \n---\n t/t3700-add.sh | 8 ++++----\n 1 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t3700-add.sh b/t/t3700-add.sh\nindex 77a782c..2ac93a3 100755\n--- a/t/t3700-add.sh\n+++ b/t/t3700-add.sh\n@@ -222,11 +222,11 @@ test_expect_success 'git add (add.ignore-errors = false)' '\n \t! ( git ls-files foo1 | grep foo1 )\n '\n \n-test_expect_success 'git add '\\''fo\\?bar'\\'' ignores foobar' '\n+test_expect_success 'git add '\\''fo\\[ou\\]bar'\\'' ignores foobar' '\n \tgit reset --hard &&\n-\ttouch fo\\?bar foobar &&\n-\tgit add '\\''fo\\?bar'\\'' &&\n-\tgit ls-files fo\\?bar | grep -F fo\\?bar &&\n+\ttouch fo\\[ou\\]bar foobar &&\n+\tgit add '\\''fo\\[ou\\]bar'\\'' &&\n+\tgit ls-files fo\\[ou\\]bar | grep -F fo\\[ou\\]bar &&\n \t! ( git ls-files foobar | grep foobar )\n '\n \n-- \n1.6.0.rc2.68.g49fa3\n\n"},{"id":"87297","messageId":"333CFE63-8410-45F5-9483-4AC6FFEB57F3@sb.org","threadId":"15017","inReplyTo":"81b0412b0808150032o20f69346jb4f573b78cd11f2b@mail.gmail.com","subject":"Re: [PATCH] Fix t3700 on filesystems which do not support question marks in names","fromName":"Kevin Ballard","fromEmail":"kevin@sb.org","sentAt":"2008-08-15T08:23:40Z","receivedAt":"2008-08-15T08:23:40Z","isPatch":true,"sender":{"key":"kevin@sb.org","avatar":"https://avatars.githubusercontent.com/u/714?v=4"},"body":"Wow, trying to use git-am to apply this patch bus errors. This isn't \ngood. Specifically, git mailinfo bus errors when the email is piped to \nit. Curiously, the attached \"patch\" is actually another MIME-formatted \nmessage with an inline patch. And I can pipe this \"patch\" to git-am \nand that works. How did you generate this message?\n\nIn any case, the patch looks good to me.\n\nSigned-off-by: Kevin Ballard \n\n-Kevin Ballard\n\nOn Aug 15, 2008, at 12:32 AM, Alex Riesen wrote:\n\n> Use square brackets instead.\n>\n> And the prominent example of the deficiency are, as usual, the \n> filesystems\n> of Microsoft house.\n>\n> Signed-off-by: Alex Riesen \n> ---\n>\n> 2008/8/15 Junio C Hamano :\n>>>> And the prominent example of the deficiency are, as usual, the \n>>>> filesystems\n>>>> of Microsoft house.\n>>>\n>>> Can other glob specials such as '*' or '[' be used instead of \n>>> skipping the\n>>> test?\n>>\n>> Ah... The brackets are allowed.\n>\n> Sorry, should have thought of it.\n>\n> t/t3700-add.sh | 8 ++++----\n> 1 files changed, 4 insertions(+), 4 deletions(-)\n> <0001-Fix-t3700-on-filesystems-which-do-not-support-questi.patch>\n\n-- \nKevin Ballard\nhttp://kevin.sb.org\nkevin@sb.org\nhttp://www.tildesoft.com\n"},{"id":"87298","messageId":"32AE3B17-2608-4C0F-93F6-E62937B332D1@sb.org","threadId":"15017","inReplyTo":"333CFE63-8410-45F5-9483-4AC6FFEB57F3@sb.org","subject":"Re: [PATCH] Fix t3700 on filesystems which do not support question marks in names","fromName":"Kevin Ballard","fromEmail":"kevin@sb.org","sentAt":"2008-08-15T08:30:05Z","receivedAt":"2008-08-15T08:30:05Z","isPatch":true,"sender":{"key":"kevin@sb.org","avatar":"https://avatars.githubusercontent.com/u/714?v=4"},"body":"On Aug 15, 2008, at 1:23 AM, Kevin Ballard wrote:\n\n> Wow, trying to use git-am to apply this patch bus errors. This isn't \n> good. Specifically, git mailinfo bus errors when the email is piped \n> to it. Curiously, the attached \"patch\" is actually another MIME- \n> formatted message with an inline patch. And I can pipe this \"patch\" \n> to git-am and that works. How did you generate this message?\n\nOk, it turns out that Don Zickus's patch \"Allow emails with boundaries \nto work again [v2]\" fixes the crash.\n\n-Kevin Ballard\n\n-- \nKevin Ballard\nhttp://kevin.sb.org\nkevin@sb.org\nhttp://www.tildesoft.com\n"},{"id":"87299","messageId":"7vhc9mbqk2.fsf@gitster.siamese.dyndns.org","threadId":"15017","inReplyTo":"81b0412b0808150032o20f69346jb4f573b78cd11f2b@mail.gmail.com","subject":"Re: [PATCH] Fix t3700 on filesystems which do not support question marks in names","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-08-15T09:01:01Z","receivedAt":"2008-08-15T09:01:01Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks. Applied.\n"}]}