Re: [PATCH] Fix t3700 on filesystems which do not support question marks in names

From: Kevin Ballard <kevin@sb.org>
Date: Aug 15, 2008, 08:23 UTC
Message-ID: <333CFE63-8410-45F5-9483-4AC6FFEB57F3@sb.org>
In-Reply-To: <81b0412b0808150032o20f69346jb4f573b78cd11f2b@mail.gmail.com>

Wow, trying to use git-am to apply this patch bus errors. This isn't good. Specifically, git mailinfo bus errors when the email is piped to it. Curiously, the attached "patch" is actually another MIME-formatted message with an inline patch. And I can pipe this "patch" to git-am and that works. How did you generate this message?

In any case, the patch looks good to me.

Signed-off-by: Kevin Ballard <kevin@sb.org>

-Kevin Ballard

On Aug 15, 2008, at 12:32 AM, Alex Riesen wrote:

Show 25 quoted lines

> Use square brackets instead.
>
> And the prominent example of the deficiency are, as usual, the  
> filesystems
> of Microsoft house.
>
> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> ---
>
> 2008/8/15 Junio C Hamano <gitster@pobox.com>:
>>>> And the prominent example of the deficiency are, as usual, the  
>>>> filesystems
>>>> of Microsoft house.
>>>
>>> Can other glob specials such as '*' or '[' be used instead of  
>>> skipping the
>>> test?
>>
>> Ah... The brackets are allowed.
>
> Sorry, should have thought of it.
>
> t/t3700-add.sh |    8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
> <0001-Fix-t3700-on-filesystems-which-do-not-support-questi.patch>

-- 
Kevin Ballard
http://kevin.sb.org
kevin@sb.org
http://www.tildesoft.com