threads / patch / 1478

patchClean generated files a bit more.

Subject: [PATCH] Clean generated files a bit more.

## tl;dr

3 messages between Aug 12, 2005 and Aug 12, 2005. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Junio C Hamano· Aug 12, 2005, 09:41 UTC · lore

Also attempt to build a source package for debian. ---

 Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

b263f24ce4f12dd39cfcd922c56a32292c6232c9

Show changes to Makefile +2 −2

diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -238,14 +238,14 @@ rpm: dist
 deb: dist
 	rm -rf $(GIT_TARNAME)
 	tar zxf $(GIT_TARNAME).tar.gz
+	dpkg-source -b $(GIT_TARNAME)
 	cd $(GIT_TARNAME) && fakeroot debian/rules binary
 
 ### Cleaning rules
 
 clean:
 	rm -f *.o mozilla-sha1/*.o ppc/*.o $(PROG) $(LIB_FILE)
-	rm -f $(GIT_TARNAME).tar.gz git-core.spec
-	rm -f git-core_$(GIT_VERSION)-*.deb git-tk_$(GIT_VERSION)-*.deb
+	rm -f git-core.spec *.deb *.dsc *.tar.gz 
 	rm -rf $(GIT_TARNAME)
 	$(MAKE) -C tools/ clean
 	$(MAKE) -C Documentation/ clean

Petr Baudis· Aug 12, 2005, 11:40 UTC · re: Junio C Hamano · lore

Re: [PATCH] Clean generated files a bit more.

Dear diary, on Fri, Aug 12, 2005 at 11:41:34AM CEST, I got a letter where Junio C Hamano <junkio@cox.net> told me that...

Show 24 quoted lines

> Also attempt to build a source package for debian.
> ---
> 
>  Makefile |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> b263f24ce4f12dd39cfcd922c56a32292c6232c9
> diff --git a/Makefile b/Makefile
> --- a/Makefile
> +++ b/Makefile
> @@ -238,14 +238,14 @@ rpm: dist
>  deb: dist
>  	rm -rf $(GIT_TARNAME)
>  	tar zxf $(GIT_TARNAME).tar.gz
> +	dpkg-source -b $(GIT_TARNAME)
>  	cd $(GIT_TARNAME) && fakeroot debian/rules binary
>  
>  ### Cleaning rules
>  
>  clean:
>  	rm -f *.o mozilla-sha1/*.o ppc/*.o $(PROG) $(LIB_FILE)
> -	rm -f $(GIT_TARNAME).tar.gz git-core.spec
> -	rm -f git-core_$(GIT_VERSION)-*.deb git-tk_$(GIT_VERSION)-*.deb
> +	rm -f git-core.spec *.deb *.dsc *.tar.gz

This makes me a bit nervous - why are you making the rules more general? make clean removing random tarballs of mine happenning to dwell in that directory is fearsome.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
If you want the holes in your knowledge showing up try teaching
someone.  -- Alan Cox

Junio C Hamano· Aug 12, 2005, 13:55 UTC · re: Petr Baudis · lore

Re: [PATCH] Clean generated files a bit more.

Petr Baudis <pasky@suse.cz> writes:

> This makes me a bit nervous - why are you making the rules more general?
> make clean removing random tarballs of mine happenning to dwell in that
> directory is fearsome.

That is a valid concern. I'd drop that *.tar.gz part at least and probably the *.deb *.dsc part as well. Thanks for sanity checking.