# [PATCH] Clean generated files a bit more.

3 messages from 2005-08-12 to 2005-08-12. Participants: Junio C Hamano, Petr Baudis.
Thread: https://gitlist.dev/t/1478

## Junio C Hamano, 2005-08-12 09:41

Subject: [PATCH] Clean generated files a bit more.
Message-ID: <7v8xz75w6p.fsf@assigned-by-dhcp.cox.net>
URL: https://gitlist.dev/e/7v8xz75w6p.fsf%40assigned-by-dhcp.cox.net

```
Also attempt to build a source package for debian.
---

 Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

b263f24ce4f12dd39cfcd922c56a32292c6232c9
diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -238,14 +238,14 @@ rpm: dist
 deb: dist
 	rm -rf $(GIT_TARNAME)
 	tar zxf $(GIT_TARNAME).tar.gz
+	dpkg-source -b $(GIT_TARNAME)
 	cd $(GIT_TARNAME) && fakeroot debian/rules binary
 
 ### Cleaning rules
 
 clean:
 	rm -f *.o mozilla-sha1/*.o ppc/*.o $(PROG) $(LIB_FILE)
-	rm -f $(GIT_TARNAME).tar.gz git-core.spec
-	rm -f git-core_$(GIT_VERSION)-*.deb git-tk_$(GIT_VERSION)-*.deb
+	rm -f git-core.spec *.deb *.dsc *.tar.gz 
 	rm -rf $(GIT_TARNAME)
 	$(MAKE) -C tools/ clean
 	$(MAKE) -C Documentation/ clean

```

## Petr Baudis, 2005-08-12 11:40

Subject: Re: [PATCH] Clean generated files a bit more.
Message-ID: <20050812114053.GB29893@pasky.ji.cz>
URL: https://gitlist.dev/e/20050812114053.GB29893%40pasky.ji.cz
In-Reply-To: <7v8xz75w6p.fsf@assigned-by-dhcp.cox.net>

```
Dear diary, on Fri, Aug 12, 2005 at 11:41:34AM CEST, I got a letter
where Junio C Hamano <junkio@cox.net> told me that...
> Also attempt to build a source package for debian.
> ---
> 
>  Makefile |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> b263f24ce4f12dd39cfcd922c56a32292c6232c9
> diff --git a/Makefile b/Makefile
> --- a/Makefile
> +++ b/Makefile
> @@ -238,14 +238,14 @@ rpm: dist
>  deb: dist
>  	rm -rf $(GIT_TARNAME)
>  	tar zxf $(GIT_TARNAME).tar.gz
> +	dpkg-source -b $(GIT_TARNAME)
>  	cd $(GIT_TARNAME) && fakeroot debian/rules binary
>  
>  ### Cleaning rules
>  
>  clean:
>  	rm -f *.o mozilla-sha1/*.o ppc/*.o $(PROG) $(LIB_FILE)
> -	rm -f $(GIT_TARNAME).tar.gz git-core.spec
> -	rm -f git-core_$(GIT_VERSION)-*.deb git-tk_$(GIT_VERSION)-*.deb
> +	rm -f git-core.spec *.deb *.dsc *.tar.gz 


This makes me a bit nervous - why are you making the rules more general?
make clean removing random tarballs of mine happenning to dwell in that
directory is fearsome.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
If you want the holes in your knowledge showing up try teaching
someone.  -- Alan Cox

```

## Junio C Hamano, 2005-08-12 13:55

Subject: Re: [PATCH] Clean generated files a bit more.
Message-ID: <7vpssj1cpi.fsf@assigned-by-dhcp.cox.net>
URL: https://gitlist.dev/e/7vpssj1cpi.fsf%40assigned-by-dhcp.cox.net
In-Reply-To: <20050812114053.GB29893@pasky.ji.cz>

```
Petr Baudis <pasky@suse.cz> writes:

> This makes me a bit nervous - why are you making the rules more general?
> make clean removing random tarballs of mine happenning to dwell in that
> directory is fearsome.

That is a valid concern.  I'd drop that *.tar.gz part at
least and probably the *.deb *.dsc part as well.  Thanks for
sanity checking.

```