{"thread":{"id":"1478","subject":"[PATCH] Clean generated files a bit more.","startedAt":"2005-08-12T09:41:34Z","lastAt":"2005-08-12T13:55:53Z","messageCount":3,"participants":["Junio C Hamano","Petr Baudis"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"7110","messageId":"7v8xz75w6p.fsf@assigned-by-dhcp.cox.net","threadId":"1478","inReplyTo":null,"subject":"[PATCH] Clean generated files a bit more.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-08-12T09:41:34Z","receivedAt":"2005-08-12T09:41:34Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Also attempt to build a source package for debian.\n---\n\n Makefile |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\nb263f24ce4f12dd39cfcd922c56a32292c6232c9\ndiff --git a/Makefile b/Makefile\n--- a/Makefile\n+++ b/Makefile\n@@ -238,14 +238,14 @@ rpm: dist\n deb: dist\n \trm -rf $(GIT_TARNAME)\n \ttar zxf $(GIT_TARNAME).tar.gz\n+\tdpkg-source -b $(GIT_TARNAME)\n \tcd $(GIT_TARNAME) && fakeroot debian/rules binary\n \n ### Cleaning rules\n \n clean:\n \trm -f *.o mozilla-sha1/*.o ppc/*.o $(PROG) $(LIB_FILE)\n-\trm -f $(GIT_TARNAME).tar.gz git-core.spec\n-\trm -f git-core_$(GIT_VERSION)-*.deb git-tk_$(GIT_VERSION)-*.deb\n+\trm -f git-core.spec *.deb *.dsc *.tar.gz \n \trm -rf $(GIT_TARNAME)\n \t$(MAKE) -C tools/ clean\n \t$(MAKE) -C Documentation/ clean\n"},{"id":"7115","messageId":"20050812114053.GB29893@pasky.ji.cz","threadId":"1478","inReplyTo":"7v8xz75w6p.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Clean generated files a bit more.","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2005-08-12T11:40:53Z","receivedAt":"2005-08-12T11:40:53Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Fri, Aug 12, 2005 at 11:41:34AM CEST, I got a letter\nwhere Junio C Hamano <junkio@cox.net> told me that...\n> Also attempt to build a source package for debian.\n> ---\n> \n>  Makefile |    4 ++--\n>  1 files changed, 2 insertions(+), 2 deletions(-)\n> \n> b263f24ce4f12dd39cfcd922c56a32292c6232c9\n> diff --git a/Makefile b/Makefile\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -238,14 +238,14 @@ rpm: dist\n>  deb: dist\n>  \trm -rf $(GIT_TARNAME)\n>  \ttar zxf $(GIT_TARNAME).tar.gz\n> +\tdpkg-source -b $(GIT_TARNAME)\n>  \tcd $(GIT_TARNAME) && fakeroot debian/rules binary\n>  \n>  ### Cleaning rules\n>  \n>  clean:\n>  \trm -f *.o mozilla-sha1/*.o ppc/*.o $(PROG) $(LIB_FILE)\n> -\trm -f $(GIT_TARNAME).tar.gz git-core.spec\n> -\trm -f git-core_$(GIT_VERSION)-*.deb git-tk_$(GIT_VERSION)-*.deb\n> +\trm -f git-core.spec *.deb *.dsc *.tar.gz \n\n\nThis makes me a bit nervous - why are you making the rules more general?\nmake clean removing random tarballs of mine happenning to dwell in that\ndirectory is fearsome.\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nIf you want the holes in your knowledge showing up try teaching\nsomeone.  -- Alan Cox\n"},{"id":"7119","messageId":"7vpssj1cpi.fsf@assigned-by-dhcp.cox.net","threadId":"1478","inReplyTo":"20050812114053.GB29893@pasky.ji.cz","subject":"Re: [PATCH] Clean generated files a bit more.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-08-12T13:55:53Z","receivedAt":"2005-08-12T13:55:53Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Petr Baudis <pasky@suse.cz> writes:\n\n> This makes me a bit nervous - why are you making the rules more general?\n> make clean removing random tarballs of mine happenning to dwell in that\n> directory is fearsome.\n\nThat is a valid concern.  I'd drop that *.tar.gz part at\nleast and probably the *.deb *.dsc part as well.  Thanks for\nsanity checking.\n"}]}